Bug 153222 - Enable API related to the video fullscreen layer in MediaPlayerPrivateAVFoundationObjC for cocoa platforms with VIDEO_PRESENTATION_MODE enabled
Summary: Enable API related to the video fullscreen layer in MediaPlayerPrivateAVFound...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-01-18 22:29 PST by Ada Chan
Modified: 2016-01-26 10:58 PST (History)
0 users

See Also:

Attachments
Patch (33.83 KB, patch)
2016-01-25 11:12 PST, Ada Chan 		no flags Details | Formatted Diff | Diff
Patch (33.85 KB, patch)
2016-01-25 11:52 PST, Ada Chan 		no flags Details | Formatted Diff | Diff
Patch (33.88 KB, patch)
2016-01-25 13:03 PST, Ada Chan 		eric.carlson: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2016-01-18 22:29:56 PST 
Enable API related to the video fullscreen layer in MediaPlayerPrivateAVFoundationObjC for all cocoa platforms. Right now they are only enabled on iOS.

These API include:
    virtual void setVideoFullscreenLayer(PlatformLayer*) override;
    virtual void setVideoFullscreenFrame(FloatRect) override;
    virtual void setVideoFullscreenGravity(MediaPlayer::VideoGravity) override;
    virtual void setVideoFullscreenMode(MediaPlayer::VideoFullscreenMode) override;
Comment 1 Ada Chan 2016-01-18 22:31:09 PST 
Part of <rdar://problem/24172052>
Comment 2 Ada Chan 2016-01-25 11:12:24 PST 
Created attachment 269765 [details]
Patch
Comment 3 Ada Chan 2016-01-25 11:31:54 PST 
Comment on attachment 269765 [details]
Patch

Fixing the iOS build error.
Comment 4 Ada Chan 2016-01-25 11:52:44 PST 
Created attachment 269776 [details]
Patch
Comment 5 Ada Chan 2016-01-25 13:03:04 PST 
Created attachment 269781 [details]
Patch
Comment 6 Ada Chan 2016-01-26 10:58:02 PST 
Committed:
http://trac.webkit.org/changeset/195595