When the build is not ready, trying to run run-webkit-tests will cause this: $ Tools/Scripts/run-webkit-tests --release --gtk Using port 'gtk-wk2' Test configuration: <, x86, release> Placing test results in /home/slave/testbuild/WebKit/WebKitBuild/Release/layout-test-results Baseline search path: gtk -> wk2 -> generic Using Release build Pixel tests disabled Regular timeout: 6000, slow test timeout: 30000 Command line: /home/slave/testbuild/WebKit/Tools/jhbuild/jhbuild-wrapper --gtk run /home/slave/testbuild/WebKit/WebKitBuild/Release/bin/WebKitTestRunner - Found 43415 tests; running 38964, skipping 4451. WebKitTestRunner was not found at /home/slave/testbuild/WebKit/WebKitBuild/Release/bin/WebKitTestRunner Build check failed AttributeError raised: PulseAudioSanitizer instance has no attribute '_pa_module_index' Traceback (most recent call last): File "/home/slave/testbuild/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 77, in main run_details = run(port, options, args, stderr) File "/home/slave/testbuild/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 409, in run run_details = manager.run(args) File "/home/slave/testbuild/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 229, in run self._clean_up_run() File "/home/slave/testbuild/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 279, in _clean_up_run self._port.clean_up_test_run() File "/home/slave/testbuild/WebKit/Tools/Scripts/webkitpy/port/gtk.py", line 110, in clean_up_test_run self._pulseaudio_sanitizer.restore_pulseaudio_module() File "/home/slave/testbuild/WebKit/Tools/Scripts/webkitpy/port/pulseaudio_sanitizer.py", line 81, in restore_pulseaudio_module if self._pa_module_index != -1: AttributeError: PulseAudioSanitizer instance has no attribute '_pa_module_index' The variable PulseAudioSanitizer._pa_module_index is set when PulseAudioSanitizer.unload_pulseaudio_module() is called from Port.setup_test_run(), which is done before calling PulseAudioSanitizer.restore_pulseaudio_module() which checks for this variable to be != -1 The issue is that when the build is not ready, Port.setup_test_run() is not run therefore the variable PulseAudioSanitizer.restore_pulseaudio_module() is not set causing this.
Created attachment 269251 [details] Patch
Comment on attachment 269251 [details] Patch Clearing flags on attachment: 269251 Committed r195245: <http://trac.webkit.org/changeset/195245>
All reviewed patches have been landed. Closing bug.