RESOLVED FIXED 153214
SVG tear offs should return a const reference if possible 
https://bugs.webkit.org/show_bug.cgi?id=153214
Summary SVG tear offs should return a const reference if possible
Nikos Andronikos
Reported 2016-01-18 16:43:40 PST
The getters SVGAnimatedStaticPropertyTearOff::baseVal() and SVGAnimatedStaticPropertyTearOff::animVal() return a reference to an SVG property object. E.g. template<typename PropertyType> class SVGAnimatedStaticPropertyTearOff : public SVGAnimatedProperty { public: virtual PropertyType& baseVal() { return m_property; } It would be preferable for the returned reference to PropertypType to be const.
Attachments
Patch (3.20 KB, patch)
2016-03-16 17:08 PDT, Nikos Andronikos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikos Andronikos
Comment 1 2016-03-16 17:08:42 PDT
Created attachment 274243 [details] Patch
WebKit Commit Bot
Comment 2 2016-03-16 20:36:13 PDT
Comment on attachment 274243 [details] Patch Clearing flags on attachment: 274243 Committed r198316: <http://trac.webkit.org/changeset/198316>
WebKit Commit Bot
Comment 3 2016-03-16 20:36:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.