Bug 153214 - SVG tear offs should return a const reference if possible
Summary: SVG tear offs should return a const reference if possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikos Andronikos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-18 16:43 PST by Nikos Andronikos
Modified: 2016-03-16 20:36 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.20 KB, patch)
2016-03-16 17:08 PDT, Nikos Andronikos 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikos Andronikos 2016-01-18 16:43:40 PST 
The getters SVGAnimatedStaticPropertyTearOff::baseVal() and SVGAnimatedStaticPropertyTearOff::animVal() return a reference to an SVG property object.

E.g.

template<typename PropertyType>
class SVGAnimatedStaticPropertyTearOff : public SVGAnimatedProperty {
public:
   virtual PropertyType& baseVal()
    {
        return m_property;
    }

It would be preferable for the returned reference to PropertypType to be const.
Comment 1 Nikos Andronikos 2016-03-16 17:08:42 PDT 
Created attachment 274243 [details]
Patch
Comment 2 WebKit Commit Bot 2016-03-16 20:36:13 PDT 
Comment on attachment 274243 [details]
Patch

Clearing flags on attachment: 274243

Committed r198316: <http://trac.webkit.org/changeset/198316>
Comment 3 WebKit Commit Bot 2016-03-16 20:36:16 PDT 
All reviewed patches have been landed.  Closing bug.