Bug 15320 - WebArchives do not embed css stylesheets referenced by xml-stylesheeet
Summary: WebArchives do not embed css stylesheets referenced by xml-stylesheeet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 15321
  Show dependency tree / graph
 
Reported: 2007-09-29 07:29 PDT by Eric Seidel (no email)
Modified: 2007-10-01 22:37 PDT (History)
1 user (show)

See Also:

Attachments
the fix (5.15 KB, patch)
2007-09-29 07:58 PDT, Eric Seidel (no email) 		oliver: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2007-09-29 07:29:13 PDT 
WebArchives do not embed stylesheets referenced by xml-stylesheeet

I'm not sure that ProcessingInstructions ever end up in the DOM, which would be the only way (it seems) that the current web archiver would be able to access the xml-stylesheet href information.
Comment 1 Eric Seidel (no email) 2007-09-29 07:58:21 PDT 
Created attachment 16450 [details]
the fix

This patch is made against feature-branch, but it just as easily could apply to trunk (except due to layout test locations)
Comment 2 Alexey Proskuryakov 2007-09-29 08:13:39 PDT 
Comment on attachment 16450 [details]
the fix

r=me (but please remove the nil check for styleSheet).

Eric says that he's going to look into what happens to XSL stylesheets in such situation.
Comment 3 Eric Seidel (no email) 2007-09-29 08:26:16 PDT 
Landed on feature-branch as r25805.
Comment 4 Oliver Hunt 2007-10-01 19:16:03 PDT 
This patch was skipped in the feature branch rebasing and will need to be updated
Comment 5 Eric Seidel (no email) 2007-10-01 22:37:23 PDT 
Relanded same patch as r25907.