What is the difference between WebKitHelpers.cmake and WebKitMacros.cmake? If nobody knows, I am thinking we should merge the contents of WebKitHelpers.cmake into WebKitMacros.cmake.
I think the two could be merged. I also think that many of the macros are only used in WebCore, and those macros should be defined in WebCore/CMakeLists.txt. cmake/WebKitMacros.cmake should be for macros that are shared by multiple projects.
+1 for merge. There are even duplications between two files, e.g. ADD_SOURCE_DEPENDENCIES
Created attachment 315445 [details] Patch
I don't like that macros (especially large ones) are thrown into thick of WebCore/CMakeLists.txt I usually try to group macros at the top of the file, though here it may be a better idea to introduce separate WebCoreMacros.cmake file Rationale is that "regular" cmake code is usually more readable (maybe almost declarative in good cases) than macro code
Created attachment 315459 [details] Patch
OK, I added WebCoreMacros.cmake. Please check to see if you approve of the hack I used to include it in WebCore/CMakeLists.txt.
Comment on attachment 315459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=315459&action=review > Source/WebCore/CMakeLists.txt:7 > +include(WebCoreMacros) Just include(WebCoreMacros.cmake), no need to change module path
Created attachment 315471 [details] Patch
(In reply to Konstantin Tokarev from comment #7) > Just include(WebCoreMacros.cmake), no need to change module path OK, good tip!
> OK, I added WebCoreMacros.cmake. Please check to see if you approve of the > hack I used to include it in WebCore/CMakeLists.txt. (In reply to Michael Catanzaro from comment #6) +1 for WebCoreMacros.cmake!
Committed r219522: <http://trac.webkit.org/changeset/219522>