Bug 153187 – Give the layout test results file a <title> showing the date and time the tests were run

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Simon Fraser (smfr)]

Give the layout test results file a <title> showing the date and time the tests were run

[Simon Fraser (smfr)]

Created attachment 269175 [details]
Patch

[Simon Fraser (smfr)]

We could also store in the JSON the OS, OS version, and maybe a hostname so you can tell which bot you're looking at?

[Alexey Proskuryakov]

Comment on attachment 269175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269175&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py:269
> +    results['date'] = datetime.datetime.now().strftime("%I:%M%p on %B %d, %Y")

I'm not quite sure what the use case for this is, however wouldn't you also need a time zone?

[Darin Adler]

Comment on attachment 269175 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269175&action=review

>> Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py:269
>> +    results['date'] = datetime.datetime.now().strftime("%I:%M%p on %B %d, %Y")
> 
> I'm not quite sure what the use case for this is, however wouldn't you also need a time zone?

Seems like a sensible thought.

[Simon Fraser (smfr)]

This is so that when I look in my History menu in Safari, I get something more descriptive than "results.html".

[WebKit Commit Bot]

Comment on attachment 269175 [details]
Patch

Clearing flags on attachment: 269175

Committed r195579: <http://trac.webkit.org/changeset/195579>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.