Bug 153184 - [GTK] Add a couple comments to ScrollbarThemeGtk
Summary: [GTK] Add a couple comments to ScrollbarThemeGtk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Trivial
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-16 06:57 PST by Michael Catanzaro
Modified: 2016-01-16 16:01 PST (History)
3 users (show)

See Also:


Attachments
Patch (1.94 KB, patch)
2016-01-16 06:58 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-yosemite (789.89 KB, application/zip)
2016-01-16 07:53 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-01-16 06:57:32 PST
Add a couple comments to ScrollbarThemeGtk to make it less confusing.
Comment 1 Michael Catanzaro 2016-01-16 06:58:50 PST
Created attachment 269165 [details]
Patch
Comment 2 Build Bot 2016-01-16 07:53:27 PST
Comment on attachment 269165 [details]
Patch

Attachment 269165 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/699072

New failing tests:
displaylists/layer-dispay-list.html
Comment 3 Build Bot 2016-01-16 07:53:28 PST
Created attachment 269167 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Carlos Garcia Campos 2016-01-16 08:34:51 PST
Comment on attachment 269165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269165&action=review

> Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:359
> +    // Cache a new GtkStyleContext for the duration of this scope.
>      TemporaryChange<GRefPtr<GtkStyleContext>> tempStyleContext(m_cachedStyleContext, getOrCreateStyleContext(scrollbar.orientation()));

This one looks redundant after the previous one, and obvious, since that's what TemporaryChange is for, but still.
Comment 5 Michael Catanzaro 2016-01-16 15:12:13 PST
(In reply to comment #4)
> This one looks redundant after the previous one, and obvious, since that's
> what TemporaryChange is for, but still.

It managed to confuse me :)
Comment 6 WebKit Commit Bot 2016-01-16 16:00:57 PST
Comment on attachment 269165 [details]
Patch

Clearing flags on attachment: 269165

Committed r195177: <http://trac.webkit.org/changeset/195177>
Comment 7 WebKit Commit Bot 2016-01-16 16:01:01 PST
All reviewed patches have been landed.  Closing bug.