Bug 153184 – [GTK] Add a couple comments to ScrollbarThemeGtk

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Add a couple comments to ScrollbarThemeGtk to make it less confusing.

[Michael Catanzaro]

Created attachment 269165 [details]
Patch

[Build Bot]

Comment on attachment 269165 [details]
Patch

Attachment 269165 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/699072

New failing tests:
displaylists/layer-dispay-list.html

[Build Bot]

Created attachment 269167 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Carlos Garcia Campos]

Comment on attachment 269165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269165&action=review

> Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:359
> +    // Cache a new GtkStyleContext for the duration of this scope.
>      TemporaryChange<GRefPtr<GtkStyleContext>> tempStyleContext(m_cachedStyleContext, getOrCreateStyleContext(scrollbar.orientation()));

This one looks redundant after the previous one, and obvious, since that's what TemporaryChange is for, but still.

[Michael Catanzaro]

(In reply to comment #4)
> This one looks redundant after the previous one, and obvious, since that's
> what TemporaryChange is for, but still.

It managed to confuse me :)

[WebKit Commit Bot]

Comment on attachment 269165 [details]
Patch

Clearing flags on attachment: 269165

Committed r195177: <http://trac.webkit.org/changeset/195177>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.