Bug 153179 - Modern IDB: Add private-browsing variant for many IDB tests, and enable private browsing in Modern IDB
Summary: Modern IDB: Add private-browsing variant for many IDB tests, and enable priva...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on: 153181
Blocks: 149117
  Show dependency treegraph
 
Reported: 2016-01-15 20:37 PST by Brady Eidson
Modified: 2016-01-18 22:02 PST (History)
5 users (show)

See Also:


Attachments
Patch v1 (726.21 KB, patch)
2016-01-18 14:19 PST, Brady Eidson
darin: review+
Details | Formatted Diff | Diff
Patch for EWS then landing (715.58 KB, patch)
2016-01-18 18:45 PST, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-01-15 20:37:35 PST
Modern IDB: Add private-browsing variant for IDB tests that already have split HTML/JS formatting

Since we'll have two separate backends (In-memory and SQLite) and will need to test both, we need a "normal" browsing HTML and private browsing HTML file for each test.

https://bugs.webkit.org/show_bug.cgi?id=153178 covers making all of the tests be split, but I'd like to make the private browsing copies now for each test that is already split; Such test coverage should be good enough to get the SQLite backend working.
Comment 1 Brady Eidson 2016-01-18 14:14:54 PST
Retitled:
Modern IDB: Add private-browsing variant for many IDB tests, and enable private browsing in Modern IDB
Comment 2 Brady Eidson 2016-01-18 14:19:15 PST
Created attachment 269237 [details]
Patch v1
Comment 3 WebKit Commit Bot 2016-01-18 14:23:41 PST
Attachment 269237 [details] did not pass style-queue:


WARNING: Not running on native Windows.
ERROR: LayoutTests/platform/wk2/TestExpectations:767:  Path does not exist.  [test/expectations] [5]
ERROR: LayoutTests/platform/wk2/TestExpectations:824:  Path does not exist.  [test/expectations] [5]
ERROR: LayoutTests/platform/wk2/TestExpectations:825:  Path does not exist.  [test/expectations] [5]
ERROR: LayoutTests/platform/wk2/TestExpectations:826:  Path does not exist.  [test/expectations] [5]
ERROR: LayoutTests/platform/wk2/TestExpectations:827:  Path does not exist.  [test/expectations] [5]
ERROR: LayoutTests/platform/wk2/TestExpectations:828:  Path does not exist.  [test/expectations] [5]
ERROR: LayoutTests/platform/wk2/TestExpectations:839:  Path does not exist.  [test/expectations] [5]
ERROR: LayoutTests/platform/wk2/TestExpectations:872:  Path does not exist.  [test/expectations] [5]
ERROR: LayoutTests/platform/wk2/TestExpectations:881:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 9 in 308 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Darin Adler 2016-01-18 15:10:22 PST
Comment on attachment 269237 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=269237&action=review

> LayoutTests/resources/js-test.js:10
> +		testRunner.setPrivateBrowsingEnabled(true);

tab here, should be 4 spaces

> Source/WebCore/ChangeLog:8
> +        Tests: storage/indexeddb/aborted-versionchange-closes-private.html

I don’t think this list of tests is valuable.
Comment 5 Brady Eidson 2016-01-18 18:30:51 PST
(In reply to comment #4)
> Comment on attachment 269237 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=269237&action=review
> 
> > LayoutTests/resources/js-test.js:10
> > +		testRunner.setPrivateBrowsingEnabled(true);
> 
> tab here, should be 4 spaces

Whoops!
 
> > Source/WebCore/ChangeLog:8
> > +        Tests: storage/indexeddb/aborted-versionchange-closes-private.html
> 
> I don’t think this list of tests is valuable.

Agreed.

Thanks!
Comment 6 Brady Eidson 2016-01-18 18:45:08 PST
Created attachment 269252 [details]
Patch for EWS then landing

I'll watch the EWS run on this then CQ+ once it's good.
Comment 7 WebKit Commit Bot 2016-01-18 22:02:46 PST
Comment on attachment 269252 [details]
Patch for EWS then landing

Clearing flags on attachment: 269252

Committed r195247: <http://trac.webkit.org/changeset/195247>
Comment 8 WebKit Commit Bot 2016-01-18 22:02:49 PST
All reviewed patches have been landed.  Closing bug.