Bug 153174 - Remove GraphicsContext::drawConvexPolygon() and GraphicsContext::clipConvexPolygon()
Summary: Remove GraphicsContext::drawConvexPolygon() and GraphicsContext::clipConvexPo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-15 19:48 PST by Simon Fraser (smfr)
Modified: 2016-01-20 21:19 PST (History)
4 users (show)

See Also:


Attachments
Patch (45.87 KB, patch)
2016-01-15 19:52 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (46.65 KB, patch)
2016-01-15 20:32 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (46.68 KB, patch)
2016-01-16 09:16 PST, Simon Fraser (smfr)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-01-15 19:48:26 PST
Remove GraphicsContext::drawConvexPolygon() and GraphicsContext::clipConvexPolygon()
Comment 1 Simon Fraser (smfr) 2016-01-15 19:52:14 PST
Created attachment 269139 [details]
Patch
Comment 2 WebKit Commit Bot 2016-01-15 19:53:08 PST
Attachment 269139 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderElement.cpp:2061:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2062:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2066:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2069:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2074:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2075:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2078:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2079:  Extra space after (  [whitespace/parens] [2]
Total errors found: 8 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2016-01-15 20:32:07 PST
Created attachment 269144 [details]
Patch
Comment 4 WebKit Commit Bot 2016-01-15 20:34:45 PST
Attachment 269144 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderElement.cpp:2061:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2062:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2066:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2069:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2074:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2075:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2078:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2079:  Extra space after (  [whitespace/parens] [2]
Total errors found: 8 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Simon Fraser (smfr) 2016-01-16 09:16:00 PST
Created attachment 269173 [details]
Patch
Comment 6 WebKit Commit Bot 2016-01-16 09:18:06 PST
Attachment 269173 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderElement.cpp:2061:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2062:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2066:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2069:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2074:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2075:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2078:  Extra space after (  [whitespace/parens] [2]
ERROR: Source/WebCore/rendering/RenderElement.cpp:2079:  Extra space after (  [whitespace/parens] [2]
Total errors found: 8 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Sam Weinig 2016-01-16 18:33:48 PST
Comment on attachment 269173 [details]
Patch

Nice simplification!
Comment 8 Simon Fraser (smfr) 2016-01-20 21:19:36 PST
http://trac.webkit.org/changeset/195170