Bug 153169 - Give RuleSet a BumpArena and start using it for RuleDataVectors.
Summary: Give RuleSet a BumpArena and start using it for RuleDataVectors.
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Keywords: Performance
Depends on:
Reported: 2016-01-15 18:11 PST by Andreas Kling
Modified: 2016-01-19 15:52 PST (History)
4 users (show)

See Also:

Patch (4.43 KB, patch)
2016-01-15 18:12 PST, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2016-01-15 18:11:00 PST
RuleSet only needs to support append operations, so it's a great candidate for BumpArena optimizations.
Comment 1 Andreas Kling 2016-01-15 18:12:14 PST
Created attachment 269135 [details]
Comment 2 Antti Koivisto 2016-01-16 11:46:14 PST
Comment 3 WebKit Commit Bot 2016-01-16 12:37:38 PST
Comment on attachment 269135 [details]

Clearing flags on attachment: 269135

Committed r195173: <http://trac.webkit.org/changeset/195173>
Comment 4 WebKit Commit Bot 2016-01-16 12:37:42 PST
All reviewed patches have been landed.  Closing bug.
Comment 5 Chris Dumez 2016-01-19 13:00:07 PST
Reverted r195173 for reason:

It relies on r195141 which was rolled out

Committed r195309: <http://trac.webkit.org/changeset/195309>
Comment 6 dewei_zhu 2016-01-19 15:52:26 PST
This change will crash JetStream on "bigfib.cpp".