We should merge <https://src.chromium.org/viewvc/blink?view=rev&revision=154215>. CSP: Update violation report 'Content-Type' header. The spec recently changed the type of violation reports from 'application/json' to 'application/csp-report'[1]. This patch implements that change by adding a type flag to the relevant PingLoader method. [1]: https://dvcs.w3.org/hg/content-security-policy/rev/9c1ebbb88a76
<rdar://problem/24383327>
Created attachment 271464 [details] Patch
I don't think we should review this large(ish) patch if it won't apply to trunk. Can you please figure out why this is failing and upload a new patch?
Comment on attachment 271464 [details] Patch Rejecting because the patch will not apply on EWS, and we can't confirm it builds properly.
Created attachment 271476 [details] Patch Rebased patch following the landing of <http://trac.webkit.org/changeset/196655> and <http://trac.webkit.org/changeset/196653>.
Comment on attachment 271476 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=271476&action=review r=me > Source/WebCore/loader/PingLoader.cpp:135 > + request.setHTTPMethod(ASCIILiteral("POST")); I've always wondered how much benefit we get from using ASCIILiteral. It seems like our String classes should be smart enough to do this automatically (but of course, that's not your issue to worry about!)
Comment on attachment 271476 [details] Patch Attachment 271476 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/841967 New failing tests: js/regress/Float64Array-to-Int16Array-set.html js/regress/Float32Array-to-Float64Array-set.html
Created attachment 271492 [details] Archive of layout-test-results from ews112 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-yosemite Platform: Mac OS X 10.10.5
Committed r196664: <http://trac.webkit.org/changeset/196664>