Bug 153166 - CSP: Update violation report 'Content-Type' header
Summary: CSP: Update violation report 'Content-Type' header
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
Keywords: BlinkMergeCandidate, InRadar
Depends on:
Reported: 2016-01-15 17:40 PST by Daniel Bates
Modified: 2016-02-16 15:22 PST (History)
8 users (show)

See Also:

Patch (18.06 KB, patch)
2016-02-16 12:15 PST, Daniel Bates
no flags Details | Formatted Diff | Diff
Patch (18.06 KB, patch)
2016-02-16 13:22 PST, Daniel Bates
bfulgham: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-yosemite (933.86 KB, application/zip)
2016-02-16 15:13 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-01-15 17:40:24 PST
We should merge <https://src.chromium.org/viewvc/blink?view=rev&revision=154215>.

CSP: Update violation report 'Content-Type' header.

The spec recently changed the type of violation reports from
'application/json' to 'application/csp-report'[1]. This patch implements
that change by adding a type flag to the relevant PingLoader method.

[1]: https://dvcs.w3.org/hg/content-security-policy/rev/9c1ebbb88a76
Comment 1 Radar WebKit Bug Importer 2016-01-27 20:55:20 PST
Comment 2 Daniel Bates 2016-02-16 12:15:52 PST
Created attachment 271464 [details]
Comment 3 Brent Fulgham 2016-02-16 12:18:25 PST
I don't think we should review this large(ish) patch if it won't apply to trunk. Can you please figure out why this is failing and upload a new patch?
Comment 4 Brent Fulgham 2016-02-16 12:18:46 PST
Comment on attachment 271464 [details]

Rejecting because the patch will not apply on EWS, and we can't confirm it builds properly.
Comment 5 Daniel Bates 2016-02-16 13:22:14 PST
Created attachment 271476 [details]

Rebased patch following the landing of <http://trac.webkit.org/changeset/196655> and <http://trac.webkit.org/changeset/196653>.
Comment 6 Brent Fulgham 2016-02-16 14:16:48 PST
Comment on attachment 271476 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=271476&action=review


> Source/WebCore/loader/PingLoader.cpp:135
> +    request.setHTTPMethod(ASCIILiteral("POST"));

I've always wondered how much benefit we get from using ASCIILiteral. It seems like our String classes should be smart enough to do this automatically (but of course, that's not your issue to worry about!)
Comment 7 Build Bot 2016-02-16 15:13:52 PST
Comment on attachment 271476 [details]

Attachment 271476 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/841967

New failing tests:
Comment 8 Build Bot 2016-02-16 15:13:56 PST
Created attachment 271492 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Daniel Bates 2016-02-16 15:22:20 PST
Committed r196664: <http://trac.webkit.org/changeset/196664>