Bug 153136 - Add kdebug_trace signposts for a few WebCore operations
Summary: Add kdebug_trace signposts for a few WebCore operations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on: 153351
Blocks:
  Show dependency tree / graph
 
Reported: 2016-01-15 10:41 PST by Simon Fraser (smfr)
Modified: 2016-01-22 02:19 PST (History)
10 users (show)

See Also:

Attachments
Patch (13.98 KB, patch)
2016-01-15 10:44 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (14.08 KB, patch)
2016-01-15 10:45 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (14.29 KB, patch)
2016-01-15 11:00 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (14.25 KB, patch)
2016-01-15 11:16 PST, Simon Fraser (smfr) 		sam: review+
Details | Formatted Diff | Diff
Patch (14.70 KB, patch)
2016-01-15 11:58 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-01-15 10:41:15 PST 
Add kdebug_trace signposts for a few WebCore operations
Comment 1 Simon Fraser (smfr) 2016-01-15 10:44:36 PST 
Created attachment 269066 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-01-15 10:45:54 PST 
Created attachment 269067 [details]
Patch
Comment 3 Simon Fraser (smfr) 2016-01-15 10:46:27 PST 
rdar://problem/24208487
Comment 4 Chris Dumez 2016-01-15 10:48:54 PST 
Comment on attachment 269067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269067&action=review

> Source/WTF/wtf/KDebugTracing.h:64
> +        : m_exitCode(exitCode)

This won't build on non-DARWIN.
Comment 5 Simon Fraser (smfr) 2016-01-15 11:00:06 PST 
Created attachment 269070 [details]
Patch
Comment 6 Chris Dumez 2016-01-15 11:02:22 PST 
Comment on attachment 269070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269070&action=review

> Source/WTF/wtf/KDebugTracing.h:68
> +#if defined(HAVE_KDEBUG_H)

Don't we usually use HAVE() macro for these?

e.g. #if HAVE(KDEBUG_H)
Comment 7 Simon Fraser (smfr) 2016-01-15 11:16:34 PST 
Created attachment 269071 [details]
Patch
Comment 8 Sam Weinig 2016-01-15 11:35:40 PST 
Comment on attachment 269071 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=269071&action=review

> Source/WTF/wtf/KDebugTracing.h:27
> +#define KDebugTracing_h

Since this is defining generic tracing utilities, perhaps this file should be called something else.  Maybe just Tracing.h?

> Source/WTF/wtf/KDebugTracing.h:64
> +class TraceEntryExit {

Maybe TraceScope?
Comment 9 Simon Fraser (smfr) 2016-01-15 11:58:05 PST 
Created attachment 269076 [details]
Patch
Comment 10 Simon Fraser (smfr) 2016-01-15 12:58:14 PST 
https://trac.webkit.org/r195142