Bug 153133 - [GTK] Fix build of RenderThemeGtk without VIDEO by including HTMLInputElement
Summary: [GTK] Fix build of RenderThemeGtk without VIDEO by including HTMLInputElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-15 09:43 PST by Olivier Blin
Modified: 2016-01-15 15:23 PST (History)
8 users (show)

See Also:

Attachments
Patch (1.55 KB, patch)
2016-01-15 09:51 PST, Olivier Blin 		no flags Details | Formatted Diff | Diff
Patch (1.46 KB, patch)
2016-01-15 14:27 PST, Olivier Blin 		no flags Details | Formatted Diff | Diff
Patch (1.46 KB, patch)
2016-01-15 14:29 PST, Olivier Blin 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Blin 2016-01-15 09:43:05 PST 
Gtk build fails when VIDEO is disabled:

WebKit/Source/WebCore/rendering/RenderThemeGtk.cpp: In member function ‘virtual bool WebCore::RenderThemeGtk::shouldHaveCapsLockIndicator(WebCore::HTMLInputElement&) const’:
WebKit/Source/WebCore/rendering/RenderThemeGtk.cpp:1045:19: error: invalid use of incomplete type ‘class WebCore::HTMLInputElement’
     return element.isPasswordField();
                   ^
Comment 1 Olivier Blin 2016-01-15 09:51:38 PST 
Created attachment 269062 [details]
Patch
Comment 2 Michael Catanzaro 2016-01-15 11:51:40 PST 
Comment on attachment 269062 [details]
Patch

Thanks. Please fix the changelog entry though; there should be the title of the bug only once, then the URL of the bug, the reviewed by line, then your description of the issue.
Comment 3 Olivier Blin 2016-01-15 14:27:23 PST 
Created attachment 269098 [details]
Patch
Comment 4 Olivier Blin 2016-01-15 14:29:08 PST 
Created attachment 269099 [details]
Patch
Comment 5 WebKit Commit Bot 2016-01-15 15:22:59 PST 
Comment on attachment 269099 [details]
Patch

Clearing flags on attachment: 269099

Committed r195153: <http://trac.webkit.org/changeset/195153>
Comment 6 WebKit Commit Bot 2016-01-15 15:23:01 PST 
All reviewed patches have been landed.  Closing bug.