Bug 153131 - [mips] Fix regT2 and regT3 trampling in MacroAssembler
Summary: [mips] Fix regT2 and regT3 trampling in MacroAssembler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-15 08:32 PST by Julien Brianceau
Modified: 2016-01-17 01:17 PST (History)
7 users (show)

See Also:


Attachments
Fix general register assignment for mips (6.05 KB, patch)
2016-01-15 08:38 PST, Julien Brianceau
no flags Details | Formatted Diff | Diff
Fix general register assignment for mips (6.05 KB, patch)
2016-01-15 08:40 PST, Julien Brianceau
msaboff: review-
Details | Formatted Diff | Diff
Fix general register assignment for mips (6.61 KB, patch)
2016-01-16 00:55 PST, Julien Brianceau
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2016-01-15 08:32:53 PST
Current mips MacroAssembler implementation clobbers regT2 and regT3 because of its addrTempRegister and cmpTempRegister.
Comment 1 Julien Brianceau 2016-01-15 08:38:01 PST
Created attachment 269056 [details]
Fix general register assignment for mips
Comment 2 Julien Brianceau 2016-01-15 08:40:30 PST
Created attachment 269057 [details]
Fix general register assignment for mips
Comment 3 Michael Saboff 2016-01-15 10:11:18 PST
Comment on attachment 269057 [details]
Fix general register assignment for mips

View in context: https://bugs.webkit.org/attachment.cgi?id=269057&action=review

> Source/JavaScriptCore/ChangeLog:7
> +

Please add a description of the change.
Comment 4 Julien Brianceau 2016-01-16 00:55:08 PST
Created attachment 269162 [details]
Fix general register assignment for mips
Comment 5 Michael Saboff 2016-01-16 17:19:44 PST
Comment on attachment 269162 [details]
Fix general register assignment for mips

r=me
Comment 6 Julien Brianceau 2016-01-17 01:17:44 PST
Manually committed r195182: http://trac.webkit.org/changeset/195182