WK1 and WK2 should share more candidate request code. After https://bugs.webkit.org/show_bug.cgi?id=153040 some things that both need were pushed into WebCore, and WK1 should use those.
Created attachment 269014 [details]
Attachment 269014 [details] did not pass style-queue:
ERROR: Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1172: Place brace on its own line for function definitions. [whitespace/braces] 
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 269014 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=269014&action=review
> +#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200
Can we turn the __MAC_OS_X_VERSION_MIN_REQUIRED >= 101200 into some kind of feature #ifdef?
> + // FIXME: Right now we only request candidates for spelling, replacement, and correction, but we plan to
> + // support more types, and we will have to update this at that time.
I don't think this comment is useful.
Thanks Simon! http://trac.webkit.org/changeset/195081