LayoutTest media/airplay-target-availability.html is flaky The test passes most of the time, but it seems to be intermittently failing with this diff: --- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/media/airplay-target-availability-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/media/airplay-target-availability-actual.txt @@ -1,9 +1,6 @@ Test that 'webkitplaybacktargetavailabilitychanged' event is sent when at least one video element has playable media. - - -EVENT: 'webkitplaybacktargetavailabilitychanged', event.availability = 'not-available' EVENT: 'webkitplaybacktargetavailabilitychanged', event.availability = 'not-available' Most recent failing run: <https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/2206> Flakiness dashboard: <http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fairplay-target-availability.html>
This is a new test, may be worth taking a look soon. Also, seems pretty clearly like a bug that we are dispatching an availability changed event when availability is the same.
<rdar://problem/24346796>
Created attachment 269883 [details] Proposed patch.
Comment on attachment 269883 [details] Proposed patch. This looks sane to me.
Comment on attachment 269883 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=269883&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=153100 Please add the radar bug under this line to make it convenient for a person to find the associated radar without having to open the WebKit bug. > Source/WebCore/Modules/mediasession/WebMediaSessionManager.cpp:361 > + LOG(Media, "WebMediaSessionManager::configurePlaybackTargetMonitoring - monitoringRequired = %i", (int)(monitoringRequired || (hasAvailabilityListener && haveClientWithMedia))); Nit: This is OK as-is. We prefer using static_cast<int> in C++ code. > LayoutTests/media/airplay-target-availability.html:22 > + video1.removeEventListener('webkitplaybacktargetavailabilitychanged', noSource, true); Nit: This is OK as-is. We seem to alternative between single and double quotes throughout this patch. We should pick one quoting style and stick without.
Committed r195592: https://trac.webkit.org/r195592