Bug 153080 - Use DFG Graph::binary/unaryArithShouldSpeculateInt32/MachineInt() functions consistently.
Summary: Use DFG Graph::binary/unaryArithShouldSpeculateInt32/MachineInt() functions c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks: 153019
  Show dependency treegraph
 
Reported: 2016-01-13 14:04 PST by Mark Lam
Modified: 2016-01-13 14:23 PST (History)
6 users (show)

See Also:


Attachments
proposed fix. (12.24 KB, patch)
2016-01-13 14:13 PST, Mark Lam
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-01-13 14:04:52 PST
We currently have Graph::mulShouldSpeculateInt32/machineInt() and Graph::negateShouldSpeculateInt32/MachineInt() functions which are only used by the ArithMul and ArithNegate nodes.  However, the same tests need to be done for many other arith nodes in the DFG.  This patch renames these functions as Graph::binaryArithShouldSpeculateInt32/machineInt() and Graph::unaryArithShouldSpeculateInt32/MachineInt(), and uses them consistently in the DFG.
Comment 1 Mark Lam 2016-01-13 14:13:53 PST
Created attachment 268902 [details]
proposed fix.
Comment 2 Geoffrey Garen 2016-01-13 14:17:04 PST
Comment on attachment 268902 [details]
proposed fix.

r=me
Comment 3 Mark Lam 2016-01-13 14:23:05 PST
Thanks for the review.  Landed in r194983: <http://trac.webkit.org/r194983>.