RESOLVED FIXED 153080
Use DFG Graph::binary/unaryArithShouldSpeculateInt32/MachineInt() functions consistently. 
https://bugs.webkit.org/show_bug.cgi?id=153080
Summary Use DFG Graph::binary/unaryArithShouldSpeculateInt32/MachineInt() functions c...
Mark Lam
Reported 2016-01-13 14:04:52 PST
We currently have Graph::mulShouldSpeculateInt32/machineInt() and Graph::negateShouldSpeculateInt32/MachineInt() functions which are only used by the ArithMul and ArithNegate nodes. However, the same tests need to be done for many other arith nodes in the DFG. This patch renames these functions as Graph::binaryArithShouldSpeculateInt32/machineInt() and Graph::unaryArithShouldSpeculateInt32/MachineInt(), and uses them consistently in the DFG.
Attachments
proposed fix. (12.24 KB, patch)
2016-01-13 14:13 PST, Mark Lam 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2016-01-13 14:13:53 PST
Created attachment 268902 [details] proposed fix.
Geoffrey Garen
Comment 2 2016-01-13 14:17:04 PST
Comment on attachment 268902 [details] proposed fix. r=me
Mark Lam
Comment 3 2016-01-13 14:23:05 PST
Thanks for the review. Landed in r194983: <http://trac.webkit.org/r194983>.
Note You need to log in before you can comment on or make changes to this bug.