Carlos made ScrollbarThemeGtk a final class, which I guess serves as an opt-in for new Clang warnings: [4498/5928] Building CXX object Source...r/platform/gtk/ScrollbarThemeGtk.cpp.o In file included from ../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:27: ../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.h:63:10: warning: 'themeChanged' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void themeChanged(); ^ ../../Source/WebCore/platform/ScrollbarTheme.h:63:18: note: overridden virtual function is here virtual void themeChanged() {} ^ 1 warning generated. [4500/5928] Building CXX object Source...GTK.dir/rendering/RenderThemeGtk.cpp.o In file included from ../../Source/WebCore/rendering/RenderThemeGtk.cpp:48: ../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.h:63:10: warning: 'themeChanged' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void themeChanged(); ^ ../../Source/WebCore/platform/ScrollbarTheme.h:63:18: note: overridden virtual function is here virtual void themeChanged() {} ^ 1 warning generated. While we're at it... most of these functions have redundant virtual specifiers and override, while the rest have only override. I prefer to omit virtual when unneeded, and we don't currently have consistency within WebKit, but most of the other functions here use it, so let's do that.
(In reply to comment #0) > Carlos made ScrollbarThemeGtk a final class, which I guess serves as an > opt-in for new Clang warnings: Nah, the problem is that none of the functions were previously marked override.
Created attachment 268896 [details] Patch
Comment on attachment 268896 [details] Patch Clearing flags on attachment: 268896 Committed r194984: <http://trac.webkit.org/changeset/194984>
All reviewed patches have been landed. Closing bug.