Bug 153074 - [GTK] Add comments above options declarations in OptionsGTK.cmake
Summary: [GTK] Add comments above options declarations in OptionsGTK.cmake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Minor
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-13 12:45 PST by Michael Catanzaro
Modified: 2016-01-13 15:06 PST (History)
6 users (show)

See Also:


Attachments
Patch (3.31 KB, patch)
2016-01-13 12:46 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-01-13 12:45:27 PST
This is to make the scheme more robust to wandering WebKit developers.
Comment 1 Michael Catanzaro 2016-01-13 12:46:40 PST
Created attachment 268894 [details]
Patch
Comment 2 Michael Catanzaro 2016-01-13 12:48:09 PST
(This patch is only for GTK, but I think the EFL, Mac, and Windows ports should consider adopting this approach to managing build options as well.)
Comment 3 WebKit Commit Bot 2016-01-13 15:06:34 PST
Comment on attachment 268894 [details]
Patch

Clearing flags on attachment: 268894

Committed r194988: <http://trac.webkit.org/changeset/194988>
Comment 4 WebKit Commit Bot 2016-01-13 15:06:37 PST
All reviewed patches have been landed.  Closing bug.