Bug 153072 - Web Inspector: Inspector should use the last sourceURL / sourceMappingURL directive
Summary: Web Inspector: Inspector should use the last sourceURL / sourceMappingURL dir...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-01-13 11:50 PST by Joseph Pecoraro
Modified: 2016-05-14 13:49 PDT (History)
12 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (18.37 KB, patch)
2016-01-13 11:55 PST, Joseph Pecoraro 		timothy: review+
Details | Formatted Diff | Diff
[PATCH] For Landing (If Bots Look Good) (18.38 KB, patch)
2016-01-13 12:29 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-01-13 11:50:22 PST 
* SUMMARY
Inspector should use the last sourceURL / sourceMappingURL directive, not the first.

In some cases, a script may have multiple sourceMappingURL directives, we should use the last.

* NOTES
- This seems to be what other browsers do (I tested Chrome and Firefox).
- I don't see this specced anywhere.
Comment 1 Joseph Pecoraro 2016-01-13 11:50:49 PST 
<rdar://problem/24168312>
Comment 2 Joseph Pecoraro 2016-01-13 11:55:20 PST 
Created attachment 268886 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2016-01-13 12:12:36 PST 
Comment on attachment 268886 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=268886&action=review

> LayoutTests/ChangeLog:12
> +        Updated line nubmer in output now that code evaluated through the frontend

Typo: number
Comment 4 Joseph Pecoraro 2016-01-13 12:29:03 PST 
Created attachment 268890 [details]
[PATCH] For Landing (If Bots Look Good)
Comment 5 BJ Burg 2016-01-13 12:33:40 PST 
Comment on attachment 268886 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=268886&action=review

> LayoutTests/inspector/debugger/sourceURLs.html:194
> +        description: "Multiple SourceURLs will return the second.",

Test coverage is beautiful. Yay!
Comment 6 BJ Burg 2016-01-13 12:33:41 PST 
Comment on attachment 268886 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=268886&action=review

> LayoutTests/inspector/debugger/sourceURLs.html:194
> +        description: "Multiple SourceURLs will return the second.",

Test coverage is beautiful. Yay!
Comment 7 WebKit Commit Bot 2016-01-13 13:32:58 PST 
Comment on attachment 268890 [details]
[PATCH] For Landing (If Bots Look Good)

Clearing flags on attachment: 268890

Committed r194981: <http://trac.webkit.org/changeset/194981>