Bug 153059 - [Streams API] Import tests updated to Jan 13 2016
Summary: [Streams API] Import tests updated to Jan 13 2016
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-13 01:59 PST by Xabier Rodríguez Calvar
Modified: 2016-01-18 05:54 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.80 KB, patch)
2016-01-13 02:04 PST, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Patch for landing (3.78 KB, patch)
2016-01-18 04:52 PST, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2016-01-13 01:59:49 PST 
[Streams API] Import tests updated to Jan 13 2016
Comment 1 Xabier Rodríguez Calvar 2016-01-13 02:03:51 PST 
This comes after comments in bug 152505.
Comment 2 Xabier Rodríguez Calvar 2016-01-13 02:04:24 PST 
Created attachment 268862 [details]
Patch
Comment 3 youenn fablet 2016-01-13 02:38:30 PST 
Comment on attachment 268862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268862&action=review

> LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/bad-strategies.js:45
> +  return promise_rejects(t, controllerError, rs.getReader().closed);

Test below has a message, but not this one.
Might be good to add one message upstream?
Comment 4 Xabier Rodríguez Calvar 2016-01-13 04:40:18 PST 
(In reply to comment #3)
> Comment on attachment 268862 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268862&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/streams-api/readable-streams/bad-strategies.js:45
> > +  return promise_rejects(t, controllerError, rs.getReader().closed);
> 
> Test below has a message, but not this one.
> Might be good to add one message upstream?

Created the pull request for this at https://github.com/whatwg/streams/pull/422.

As soon as it gets accepted, I'll land it here too.
Comment 5 Xabier Rodríguez Calvar 2016-01-18 04:52:43 PST 
Created attachment 269216 [details]
Patch for landing
Comment 6 Xabier Rodríguez Calvar 2016-01-18 04:53:13 PST 
(In reply to comment #4)
> > Test below has a message, but not this one.
> > Might be good to add one message upstream?
> 
> Created the pull request for this at
> https://github.com/whatwg/streams/pull/422.
> 
> As soon as it gets accepted, I'll land it here too.

The pull request was not accepted, so I am landing this here.
Comment 7 WebKit Commit Bot 2016-01-18 05:54:51 PST 
Comment on attachment 269216 [details]
Patch for landing

Clearing flags on attachment: 269216

Committed r195229: <http://trac.webkit.org/changeset/195229>
Comment 8 WebKit Commit Bot 2016-01-18 05:54:53 PST 
All reviewed patches have been landed.  Closing bug.