Bug 153053 - [Cocoa] Font features are not applied to the system font
Summary: [Cocoa] Font features are not applied to the system font
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-01-12 19:32 PST by Myles C. Maxfield
Modified: 2016-01-15 14:59 PST (History)
8 users (show)

See Also:

Attachments
Patch (4.08 KB, patch)
2016-01-12 19:33 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (3.98 KB, patch)
2016-01-12 19:42 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-01-12 19:32:32 PST 
[Cocoa] Font features are not applied to the system font
Comment 1 Myles C. Maxfield 2016-01-12 19:33:18 PST 
Created attachment 268846 [details]
Patch
Comment 2 Myles C. Maxfield 2016-01-12 19:42:18 PST 
Created attachment 268849 [details]
Patch
Comment 3 Jon Lee 2016-01-13 11:54:19 PST 
Comment on attachment 268849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268849&action=review

> LayoutTests/fast/text/system-font-features-expected.html:7
> +<div style="font: 50px -apple-system-monospaced-numbers;">0123456789</div>

Eventually we're going to want to remove this style. Is there another way we could write this test?
Comment 4 Jon Lee 2016-01-13 12:11:20 PST 
<rdar://problem/24173613>
Comment 5 Myles C. Maxfield 2016-01-13 17:21:16 PST 
Comment on attachment 268849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268849&action=review

>> LayoutTests/fast/text/system-font-features-expected.html:7
>> +<div style="font: 50px -apple-system-monospaced-numbers;">0123456789</div>
> 
> Eventually we're going to want to remove this style. Is there another way we could write this test?

I tried, but unfortunately it looks like I can't use -mismatch-expected results because of the system font mocking we are doing for testing. :(
Comment 6 WebKit Commit Bot 2016-01-15 14:58:59 PST 
Comment on attachment 268849 [details]
Patch

Clearing flags on attachment: 268849

Committed r195150: <http://trac.webkit.org/changeset/195150>
Comment 7 WebKit Commit Bot 2016-01-15 14:59:02 PST 
All reviewed patches have been landed.  Closing bug.