Bug 153015 - [GTK] Fix return value of some paint methods in RenderThemeGtk
Summary: [GTK] Fix return value of some paint methods in RenderThemeGtk
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2016-01-12 08:55 PST by Carlos Garcia Campos
Modified: 2016-01-12 22:47 PST (History)
5 users (show)

See Also:


Attachments
Patch (6.28 KB, patch)
2016-01-12 08:57 PST, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-01-12 08:55:22 PST
It's a bit confusing, but the bool value returned by paint methods in RenderTheme means whether the appearance is supported or not, so we should return true when not supported (so we didn't paint anything) and false when supported (so we actually painted the theme part).
Comment 1 Carlos Garcia Campos 2016-01-12 08:57:13 PST
Created attachment 268772 [details]
Patch
Comment 2 Michael Catanzaro 2016-01-12 11:22:50 PST
Comment on attachment 268772 [details]
Patch

Watch the bots....
Comment 3 Carlos Garcia Campos 2016-01-12 22:47:31 PST
Committed r194955: <http://trac.webkit.org/changeset/194955>