Bug 153007 - Web Inspector: Sidebar's should remember their width's
Summary: Web Inspector: Sidebar's should remember their width's
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-01-12 00:49 PST by Devin Rousso
Modified: 2016-01-22 10:08 PST (History)
8 users (show)

See Also:


Attachments
Patch (5.05 KB, patch)
2016-01-21 22:57 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2016-01-12 00:49:52 PST
r194879 <https://bugs.webkit.org/show_bug.cgi?id=152473> introduced the ability for sidebar panels to calculate their minimum widths.  This functionality works correctly, but there is an issue when the user switches to a view with the sidebar collapsed and then switches back to the first view.  Since the second view essentially had a sidebar width of 0, the first view recalculates the width of the sidebar to its minimum, regardless of how large the user had it before he changed views.  It is very annoying to have to keep resizing the sidebar to a larger width, so I think it would be better to have the sidebar's remember their previous width and restore it (clamped to the min/max of the current inspector width) whenever a view changes.
Comment 1 Radar WebKit Bug Importer 2016-01-14 18:29:30 PST
<rdar://problem/24200496>
Comment 2 Devin Rousso 2016-01-21 22:57:36 PST
Created attachment 269552 [details]
Patch
Comment 3 WebKit Commit Bot 2016-01-22 10:08:09 PST
Comment on attachment 269552 [details]
Patch

Clearing flags on attachment: 269552

Committed r195456: <http://trac.webkit.org/changeset/195456>
Comment 4 WebKit Commit Bot 2016-01-22 10:08:14 PST
All reviewed patches have been landed.  Closing bug.