* STEPS TO REPRODUCE 1. Go to <www.apple.com> 2. Inspect the <body> 3. In the Visual sidebar, go to Background > Style 4. Click the + button on the list editor and select "Linear Gradient" in the dropdown next to "Type" 5. Click the swatch element immediately to the right of the "Type" label (the gradient editor should open) 6. Click slightly underneath the gradient preview area to add a color stop * Expected Color stop is added to (previously empty) gradient * Actual Crashes
Created attachment 268744 [details] Patch
By crash, do you mean that WebCore crashed? We should also investigate fixing that, as invalid CSS from the inspector should never cause a segfault.
Comment on attachment 268744 [details] Patch r=me
(In reply to comment #2) > By crash, do you mean that WebCore crashed? We should also investigate > fixing that, as invalid CSS from the inspector should never cause a segfault. Oh no just Web Inspector crashes. I get that "Uncaught Exception" page. I figured that that was considered a "crash" for the Web Inspector. Is there a better term for it?
(In reply to comment #4) > (In reply to comment #2) > > By crash, do you mean that WebCore crashed? We should also investigate > > fixing that, as invalid CSS from the inspector should never cause a segfault. > > Oh no just Web Inspector crashes. I get that "Uncaught Exception" page. I > figured that that was considered a "crash" for the Web Inspector. Is there > a better term for it? That's an uncaught exception, and is less severe. The dialog only appears in engineering builds and can be dismissed. A crash occurs when the Web Inspector or Safari window disappears completely and a crash report is collected. If that happens, you can see the stack trace dumped to stdout or added to the list in Console.app.
(In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #2) > > > By crash, do you mean that WebCore crashed? We should also investigate > > > fixing that, as invalid CSS from the inspector should never cause a segfault. > > > > Oh no just Web Inspector crashes. I get that "Uncaught Exception" page. I > > figured that that was considered a "crash" for the Web Inspector. Is there > > a better term for it? > > That's an uncaught exception, and is less severe. The dialog only appears in > engineering builds and can be dismissed. > > A crash occurs when the Web Inspector or Safari window disappears completely > and a crash report is collected. If that happens, you can see the stack > trace dumped to stdout or added to the list in Console.app. Ah OK that makes more sense. I'll refer to it as such in the future. Sorry for the confusion!
Comment on attachment 268744 [details] Patch Clearing flags on attachment: 268744 Committed r194901: <http://trac.webkit.org/changeset/194901>
All reviewed patches have been landed. Closing bug.
<rdar://problem/24191708>