* SUMMARY Move helper methods for getting icons/text to TimelineTabContentView. Static methods in TimelineSidebarPanel can simply be moved. Code for getting icons and titles for timeline records should be broken out of TimelineRecordTreeElement, and made into helper methods. Refactoring this will simplify removing the Timelines navigation sidebar in the near future.
Created attachment 268726 [details] [Patch] Proposed Fix
Comment on attachment 268726 [details] [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=268726&action=review r=me > Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js:35 > + if (includeDetailsInMainTitle && timelineRecord.type === WebInspector.TimelineRecord.Type.Script && timelineRecord.eventType === WebInspector.ScriptTimelineRecord.EventType.TimerInstalled) { This change isn't described in the changelog. It seems to be extracted from... > Source/WebInspectorUI/UserInterface/Views/TimelineRecordTreeElement.js:-100 > - let timeoutString = Number.secondsToString(timelineRecord.details.timeout / 1000); .. here
Created attachment 268816 [details] [Patch] Proposed Fix
Comment on attachment 268816 [details] [Patch] Proposed Fix Clearing flags on attachment: 268816 Committed r194932: <http://trac.webkit.org/changeset/194932>
All reviewed patches have been landed. Closing bug.