Bug 152991 – Web Inspector: Fix DataGrid row disclosure appearance and behavior

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

* SUMMARY
Fix DataGrid row disclosure appearance and behavior. Positioning and hit testing of the disclosure triangle has been broken for a while, but has gone unnoticed since it's not currently used.

[Matt Baker]

Created attachment 268719 [details]
[Patch] Proposed Fix

[Blaze Burg]

Comment on attachment 268719 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=268719&action=review

r=me

Was there a specific regression, or was this a result of various stylesheet changes?

> Source/WebInspectorUI/UserInterface/Views/DataGrid.js:1854
> +        let computedLeftPadding = window.getComputedStyle(cell).getPropertyCSSValue("padding-left").getFloatValue(CSSPrimitiveValue.CSS_PX);

Fancy.

[Matt Baker]

(In reply to comment #2)
> Comment on attachment 268719 [details]
> [Patch] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268719&action=review
> 
> r=me
> 
> Was there a specific regression, or was this a result of various stylesheet
> changes?

Not sure. It's been so long since this has been used that I assumed the code just drifted over time and the breakage went unnoticed.

> 
> > Source/WebInspectorUI/UserInterface/Views/DataGrid.js:1854
> > +        let computedLeftPadding = window.getComputedStyle(cell).getPropertyCSSValue("padding-left").getFloatValue(CSSPrimitiveValue.CSS_PX);
> 
> Fancy.

Copied from TreeElement.prototype.isEventWithinDisclosureTriangle.

[WebKit Commit Bot]

Comment on attachment 268719 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 268719

Committed r194906: <http://trac.webkit.org/changeset/194906>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/24193237>