Bug 152982 - Standardize the usage of "branch" vs. "branchName".
Summary: Standardize the usage of "branch" vs. "branchName".
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on: 152910
  Show dependency treegraph
Reported: 2016-01-11 12:15 PST by Jason Marcell
Modified: 2016-01-14 14:33 PST (History)
7 users (show)

See Also:

Patch (8.09 KB, patch)
2016-01-11 12:18 PST, Jason Marcell
no flags Details | Formatted Diff | Diff
Patch (138.28 KB, patch)
2016-01-11 14:18 PST, Jason Marcell
no flags Details | Formatted Diff | Diff
Patch (8.22 KB, patch)
2016-01-11 17:03 PST, Jason Marcell
dbates: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Marcell 2016-01-11 12:15:10 PST
Standardize the usage of "branch" vs. "branchName".
Comment 1 Jason Marcell 2016-01-11 12:18:59 PST
Created attachment 268702 [details]
Comment 2 Daniel Bates 2016-01-11 13:02:20 PST
Comment on attachment 268702 [details]


cq- since this patch depends on the patch for bug #152910 and it has not landed as of the time of writing.
Comment 3 Jason Marcell 2016-01-11 14:18:26 PST
Created attachment 268710 [details]
Comment 4 Jason Marcell 2016-01-11 14:30:43 PST
(In reply to comment #3)
> Created attachment 268710 [details]
> Patch

This patch was not supposed to be uploaded here nor was the original patch supposed to be obsoleted. The webkit-patch command did this erroneously. I've written up a bug to track this erroneous behavior: https://bugs.webkit.org/show_bug.cgi?id=152987
Comment 5 Jason Marcell 2016-01-11 17:03:11 PST
Created attachment 268730 [details]
Comment 6 Jason Marcell 2016-01-11 17:04:15 PST
Comment on attachment 268730 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=268730&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:69
> +            return (!commit.containsBranchLocation || commit.branchName === branchName) && filter(commit);

I had accidentally left this change out of the original patch.
Comment 7 Jason Marcell 2016-01-14 14:33:47 PST
Landed: https://trac.webkit.org/changeset/195076