Bug 152974 - [WK2][GTK] Propagate motion-notify-event signals from the WebView
Summary: [WK2][GTK] Propagate motion-notify-event signals from the WebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2016-01-11 02:34 PST by Mario Sanchez Prada
Modified: 2016-01-11 03:32 PST (History)
8 users (show)

See Also:


Attachments
Patch proposal (2.43 KB, patch)
2016-01-11 02:51 PST, Mario Sanchez Prada
cgarcia: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Sanchez Prada 2016-01-11 02:34:47 PST
As it was brought up in the mailing list recently[1], there are some signals for which the default handlers in the WebView prevent them from being propagated as there is no way to know, in a multi-process model, when the WebProcess have actually processed them or not (they should be propagated when not processed). See more detailed explanation in [2].

Options proposed were, mainly, to either store the event in the UI process and re-emit later once we know the Web process has not been handled (as done for key events) or simply to return FALSE to always propagate them, which sounds like a good option for events like motion-event-notify, which do not act over any specific target (see [3] for a better explanation of the rationale behind).

I discussed this with Carlos on IRC and he agrees on doing that change for motion events, so tracking that change here.

[1] https://lists.webkit.org/pipermail/webkit-gtk/2016-January/002498.html
[2] https://lists.webkit.org/pipermail/webkit-gtk/2016-January/002500.html
[3] https://lists.webkit.org/pipermail/webkit-gtk/2016-January/002505.html
Comment 1 Mario Sanchez Prada 2016-01-11 02:51:23 PST
Created attachment 268681 [details]
Patch proposal
Comment 2 WebKit Commit Bot 2016-01-11 02:53:57 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Mario Sanchez Prada 2016-01-11 03:32:28 PST
Committed r194846: <http://trac.webkit.org/changeset/194846>