Bug 152971 - run-jsc-stress-tests should try to figure out a JSC path
Summary: run-jsc-stress-tests should try to figure out a JSC path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-10 23:52 PST by Saam Barati
Modified: 2016-01-11 20:41 PST (History)
11 users (show)

See Also:

Attachments
patch (3.55 KB, patch)
2016-01-11 00:06 PST, Saam Barati 		ysuzuki: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-01-10 23:52:48 PST 
If it does, we can run it just like this:
`run-esc-stress-tests <directory/to/some/tests> <path/to/a/yaml>`
Comment 1 Saam Barati 2016-01-11 00:06:17 PST 
Created attachment 268677 [details]
patch
Comment 2 Yusuke Suzuki 2016-01-11 00:25:39 PST 
Comment on attachment 268677 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268677&action=review

r=me

> Tools/Scripts/run-jsc-stress-tests:264
> +        jscArg = Pathname.new(output).join("JavaScriptCore.framework").join("Resources").join("jsc")

Nits: we can write this as `Pathname.new(output).join("JavaScriptCore.framework", "Resources", "jsc")`.

> Tools/Scripts/run-jsc-stress-tests:265
> +    end

And by adding one more fallback, `Pathname.new(output).join("bin", "jsc")`, we can support EFL / GTK.
Comment 3 Saam Barati 2016-01-11 20:41:10 PST 
(In reply to comment #2)
> Comment on attachment 268677 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268677&action=review
> 
> r=me
> 
> > Tools/Scripts/run-jsc-stress-tests:264
> > +        jscArg = Pathname.new(output).join("JavaScriptCore.framework").join("Resources").join("jsc")
> 
> Nits: we can write this as
> `Pathname.new(output).join("JavaScriptCore.framework", "Resources", "jsc")`.
> 
> > Tools/Scripts/run-jsc-stress-tests:265
> > +    end
> 
> And by adding one more fallback, `Pathname.new(output).join("bin", "jsc")`,
> we can support EFL / GTK.

Thanks for the review
Comment 4 Saam Barati 2016-01-11 20:41:36 PST 
landed in:
http://trac.webkit.org/changeset/194885