WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
152970
Modify for a shell version of JetStream
https://bugs.webkit.org/show_bug.cgi?id=152970
Summary
Modify for a shell version of JetStream
Shiyu Zhang
Reported
2016-01-10 22:46:11 PST
Created
attachment 268672
[details]
Change JetStream from web-version to shell-version I modified the web-version JetStream to run in the shell. The main change is to replace document.open/write/close with load to run the JS test cases. The modified shell-version of JetStream has been tested with JavaScriptCore successfully. Could you please help to verify it? Thanks!
Attachments
Change JetStream from web-version to shell-version
(21.30 KB, patch)
2016-01-10 22:46 PST
,
Shiyu Zhang
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Filip Pizlo
Comment 1
2016-01-11 07:39:59 PST
I don't agree with this. JetStream is not meaningful when run outside of the browser since it has tests that behave very differently when you exclude the browser's heap and runloop. we don't want to give people the impression that running on command line is somehow valid. Also, I don't think we want to maintain two versions of the JetStream harness. That patch you have put up has dramatic changes and I don't think we want to maintain them just for your convenience.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug