Bug 152970 - Modify for a shell version of JetStream
Summary: Modify for a shell version of JetStream
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-10 22:46 PST by Shiyu Zhang
Modified: 2016-01-11 07:39 PST (History)
2 users (show)

See Also:


Attachments
Change JetStream from web-version to shell-version (21.30 KB, patch)
2016-01-10 22:46 PST, Shiyu Zhang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shiyu Zhang 2016-01-10 22:46:11 PST
Created attachment 268672 [details]
Change JetStream from web-version to shell-version

I modified the web-version JetStream to run in the shell. The main change is to replace document.open/write/close with load to run the JS test cases.
The modified shell-version of JetStream has been tested with JavaScriptCore successfully.
Could you please help to verify it? Thanks!
Comment 1 Filip Pizlo 2016-01-11 07:39:59 PST
I don't agree with this. JetStream is not meaningful when run outside of the browser since it has tests that behave very differently when you exclude the browser's heap and runloop. we don't want to give people the impression that running on command line is somehow valid. 

Also, I don't think we want to maintain two versions of the JetStream harness. That patch you have put up has dramatic changes and I don't think we want to maintain them just for your convenience.