Bug 152968 - Turn Check(true) into Patchpoint() followed by Oops
Summary: Turn Check(true) into Patchpoint() followed by Oops
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 152162 150507
  Show dependency tree / graph
 
Reported: 2016-01-10 20:11 PST by Filip Pizlo
Modified: 2016-01-11 09:18 PST (History)
5 users (show)

See Also:

Attachments
the patch (8.00 KB, patch)
2016-01-10 20:16 PST, Filip Pizlo 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-01-10 20:11:59 PST 
Patch forthcoming.
Comment 1 Filip Pizlo 2016-01-10 20:16:24 PST 
Created attachment 268669 [details]
the patch
Comment 2 WebKit Commit Bot 2016-01-10 20:18:07 PST 
Attachment 268669 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3InsertionSet.h:65:  The parameter name "arguments" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Benjamin Poulain 2016-01-11 04:54:57 PST 
Comment on attachment 268669 [details]
the patch

IMHO, it would be valuable to have 2 new tests in testbed for the new strength reduction.
Comment 4 Filip Pizlo 2016-01-11 09:15:26 PST 
(In reply to comment #3)
> Comment on attachment 268669 [details]
> the patch
> 
> IMHO, it would be valuable to have 2 new tests in testbed for the new
> strength reduction.

I added such tests.
Comment 5 Filip Pizlo 2016-01-11 09:18:54 PST 
Landed in http://trac.webkit.org/changeset/194855