Bug 152964 - [GTK] Remove jhbuild-optional.modules
Summary: [GTK] Remove jhbuild-optional.modules
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-10 13:22 PST by Michael Catanzaro
Modified: 2016-01-19 07:40 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.24 KB, patch)
2016-01-10 13:25 PST, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-yosemite (857.29 KB, application/zip)
2016-01-10 14:16 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-01-10 13:22:35 PST 
This moduleset is not used for anything and does not seem useful. The description says "This file contains a set of modules that are hard to get on certain distributions" but I have a hard time believing any distro that can run WebKitGTK+ ships without libsecret, dconf, or vala.
Comment 1 Michael Catanzaro 2016-01-10 13:25:12 PST 
Created attachment 268661 [details]
Patch
Comment 2 Michael Catanzaro 2016-01-10 13:26:09 PST 
(Note: 'jhbuild run gsettings' works to change settings inside the jhbuild environment. You shouldn't need to rebuild dconf.)
Comment 3 Build Bot 2016-01-10 14:16:35 PST 
Comment on attachment 268661 [details]
Patch

Attachment 268661 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/676097

New failing tests:
storage/indexeddb/cursor-update.html
Comment 4 Build Bot 2016-01-10 14:16:37 PST 
Created attachment 268663 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Michael Catanzaro 2016-01-10 14:36:45 PST 
(In reply to comment #4)
> Created attachment 268663 [details]
> Archive of layout-test-results from ews116 for mac-yosemite
> 
> The attached test failures were seen while running run-webkit-tests on the
> mac-debug-ews.
> Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Filed bug #152965.
Comment 6 WebKit Commit Bot 2016-01-19 07:40:53 PST 
Comment on attachment 268661 [details]
Patch

Clearing flags on attachment: 268661

Committed r195287: <http://trac.webkit.org/changeset/195287>
Comment 7 WebKit Commit Bot 2016-01-19 07:40:55 PST 
All reviewed patches have been landed.  Closing bug.