Bug 152964 – [GTK] Remove jhbuild-optional.modules

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

This moduleset is not used for anything and does not seem useful. The description says "This file contains a set of modules that are hard to get on certain distributions" but I have a hard time believing any distro that can run WebKitGTK+ ships without libsecret, dconf, or vala.

[Michael Catanzaro]

Created attachment 268661 [details]
Patch

[Michael Catanzaro]

(Note: 'jhbuild run gsettings' works to change settings inside the jhbuild environment. You shouldn't need to rebuild dconf.)

[Build Bot]

Comment on attachment 268661 [details]
Patch

Attachment 268661 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/676097

New failing tests:
storage/indexeddb/cursor-update.html

[Build Bot]

Created attachment 268663 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Michael Catanzaro]

(In reply to comment #4)
> Created attachment 268663 [details]
> Archive of layout-test-results from ews116 for mac-yosemite
> 
> The attached test failures were seen while running run-webkit-tests on the
> mac-debug-ews.
> Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Filed bug #152965.

[WebKit Commit Bot]

Comment on attachment 268661 [details]
Patch

Clearing flags on attachment: 268661

Committed r195287: <http://trac.webkit.org/changeset/195287>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.