Bug 152963 - It should be possible to run liveness over registers without also tracking Tmps
Summary: It should be possible to run liveness over registers without also tracking Tmps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 150279
  Show dependency treegraph
 
Reported: 2016-01-10 11:24 PST by Filip Pizlo
Modified: 2016-01-10 16:59 PST (History)
8 users (show)

See Also:


Attachments
the patch (15.80 KB, patch)
2016-01-10 11:46 PST, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-01-10 11:24:04 PST
Tracking Tmps is expensive, tracking Regs is cheap.  We sometimes need to compute liveness of Regs only.  That should be cheap and not expensive.
Comment 1 Filip Pizlo 2016-01-10 11:46:46 PST
Created attachment 268660 [details]
the patch

Not ready for review yet because I haven't run all of the tests yet.
Comment 2 WebKit Commit Bot 2016-01-10 12:05:32 PST
Attachment 268660 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/air/AirInstInlines.h:82:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Saam Barati 2016-01-10 14:01:43 PST
Comment on attachment 268660 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268660&action=review

r=me

> Source/WTF/ChangeLog:15
> +        BitVector other than this, so it doesn't make sense to made it harder to access.

made=>make
Comment 4 Filip Pizlo 2016-01-10 16:59:08 PST
Landed in http://trac.webkit.org/changeset/194834