Bug 152960 – CSSValuePool should use nonfragmented storage for eternal caches.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Andreas Kling]

The cached CSSValue objects in CSSValuePool get allocated at different times. It would be better if they didn't end up all over the heap.

[Andreas Kling]

Created attachment 268651 [details]
Patch

[Build Bot]

Comment on attachment 268651 [details]
Patch

Attachment 268651 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/675482

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 268652 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Andreas Kling]

Created attachment 268659 [details]
Patch

[Andreas Kling]

Created attachment 268666 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 268666 [details]
Patch

Rejecting attachment 268666 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 268666, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://webkit-queues.webkit.org/results/677999

[WebKit Commit Bot]

Comment on attachment 268666 [details]
Patch

Rejecting attachment 268666 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 268666, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
a/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run
    if changelog_entry.has_valid_reviewer():
AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer'

Full output: http://webkit-queues.webkit.org/results/678176

[Andreas Kling]

Created attachment 268683 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 268683 [details]
Patch for landing

Clearing flags on attachment: 268683

Committed r194848: <http://trac.webkit.org/changeset/194848>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Andreas Kling]

Windows build fix coming up..