Bug 152945 – REGRESSION (r194426): First email field is not autofilled on amazon.com

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

1. go to https://www.amazon.com/ap/register?_encoding=UTF8&openid.assoc_handle=usflex&openid.claimed_id=http%3A%2F%2Fspecs.openid.net%2Fauth%2F2.0%2Fidentifier_select&openid.identity=http%3A%2F%2Fspecs.openid.net%2Fauth%2F2.0%2Fidentifier_select&openid.mode=checkid_setup&openid.ns=http%3A%2F%2Fspecs.openid.net%2Fauth%2F2.0&openid.ns.pape=http%3A%2F%2Fspecs.openid.net%2Fextensions%2Fpape%2F1.0&openid.pape.max_auth_age=0&openid.return_to=https%3A%2F%2Fwww.amazon.com%2Fgp%2Fyourstore%2Fhome%3Fie%3DUTF8%26ref_%3Dnav_newcust
2. cmd-shift-A or click and arrow down to select autofill options.

* RESULTS
First email field is not filled, second email is filled.

[zalan]

rdar://problem/24082914

[zalan]

Created attachment 268622 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 268622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268622&action=review

> Source/WebCore/ChangeLog:11
> +        Unable to test. Needs Safari autofill interaction.

This is a shame. Can't you simulate it with two text fields?

> Source/WebCore/page/FrameView.cpp:2651
> +        // We already have a pending (full) layout. Just mark the subtree for layout.

I can't see how you know you have a pending layout here.

[zalan]

(In reply to comment #3)
> Comment on attachment 268622 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268622&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        Unable to test. Needs Safari autofill interaction.
> 
> This is a shame. Can't you simulate it with two text fields?
I might.

> 
> > Source/WebCore/page/FrameView.cpp:2651
> > +        // We already have a pending (full) layout. Just mark the subtree for layout.
> 
> I can't see how you know you have a pending layout here.
We early return from this function when layout is pending.

[zalan]

Created attachment 268629 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 268629 [details]
Patch

Clearing flags on attachment: 268629

Committed r194823: <http://trac.webkit.org/changeset/194823>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.