Bug 152945 - REGRESSION (r194426): First email field is not autofilled on amazon.com
Summary: REGRESSION (r194426): First email field is not autofilled on amazon.com
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-01-09 09:17 PST by zalan
Modified: 2016-01-09 16:39 PST (History)
2 users (show)

See Also:


Attachments
Patch (2.12 KB, patch)
2016-01-09 09:41 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (4.45 KB, patch)
2016-01-09 15:05 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 zalan 2016-01-09 09:18:05 PST
rdar://problem/24082914
Comment 2 zalan 2016-01-09 09:41:54 PST
Created attachment 268622 [details]
Patch
Comment 3 Simon Fraser (smfr) 2016-01-09 10:38:55 PST
Comment on attachment 268622 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268622&action=review

> Source/WebCore/ChangeLog:11
> +        Unable to test. Needs Safari autofill interaction.

This is a shame. Can't you simulate it with two text fields?

> Source/WebCore/page/FrameView.cpp:2651
> +        // We already have a pending (full) layout. Just mark the subtree for layout.

I can't see how you know you have a pending layout here.
Comment 4 zalan 2016-01-09 14:05:35 PST
(In reply to comment #3)
> Comment on attachment 268622 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268622&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        Unable to test. Needs Safari autofill interaction.
> 
> This is a shame. Can't you simulate it with two text fields?
I might.

> 
> > Source/WebCore/page/FrameView.cpp:2651
> > +        // We already have a pending (full) layout. Just mark the subtree for layout.
> 
> I can't see how you know you have a pending layout here.
We early return from this function when layout is pending.
Comment 5 zalan 2016-01-09 15:05:54 PST
Created attachment 268629 [details]
Patch
Comment 6 WebKit Commit Bot 2016-01-09 16:39:12 PST
Comment on attachment 268629 [details]
Patch

Clearing flags on attachment: 268629

Committed r194823: <http://trac.webkit.org/changeset/194823>
Comment 7 WebKit Commit Bot 2016-01-09 16:39:16 PST
All reviewed patches have been landed.  Closing bug.