Bug 152942 - Use a profile to store allocation structures for subclasses of InternalFunctions
Summary: Use a profile to store allocation structures for subclasses of InternalFunctions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
: 152710 (view as bug list)
Depends on:
Blocks: 142591 152949
  Show dependency tree / graph
 
Reported: 2016-01-08 22:04 PST by Keith Miller
Modified: 2016-01-27 14:37 PST (History)
6 users (show)

See Also:

Attachments
Patch (73.02 KB, patch)
2016-01-08 22:21 PST, Keith Miller 		msaboff: review+
Details | Formatted Diff | Diff
Benchmark results (64.80 KB, text/plain)
2016-01-09 16:26 PST, Keith Miller 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-01-08 22:04:58 PST 
Use a profile to store allocation structures for subclasses of InternalFunctions
Comment 1 Keith Miller 2016-01-08 22:21:01 PST 
Created attachment 268614 [details]
Patch
Comment 2 Keith Miller 2016-01-09 16:26:45 PST 
Created attachment 268630 [details]
Benchmark results
Comment 3 Michael Saboff 2016-01-11 13:14:03 PST 
Comment on attachment 268614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268614&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +        This patch adds InternalFunctionAlloctationProfile to FunctionRareData, which holds

Spelling *InternalFunctionAllocationProfile*

> Source/JavaScriptCore/ChangeLog:10
> +        InternalFunctionAlloctationProfile ended up being distinct from ObjectAlloctationProfile, due to

ditto spelling.
Comment 4 Keith Miller 2016-01-11 13:25:31 PST 
Comment on attachment 268614 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268614&action=review

>> Source/JavaScriptCore/ChangeLog:8
>> +        This patch adds InternalFunctionAlloctationProfile to FunctionRareData, which holds
> 
> Spelling *InternalFunctionAllocationProfile*

Fixed.

>> Source/JavaScriptCore/ChangeLog:10
>> +        InternalFunctionAlloctationProfile ended up being distinct from ObjectAlloctationProfile, due to
> 
> ditto spelling.

Fixed both Alloctations.
Comment 5 Keith Miller 2016-01-11 13:31:19 PST 
Committed r194863: <http://trac.webkit.org/changeset/194863>
Comment 6 Csaba Osztrogonác 2016-01-12 03:22:59 PST 
(In reply to comment #5)
> Committed r194863: <http://trac.webkit.org/changeset/194863>

It broke the Apple Mac cmake build:
https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/1536

/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/JavaScriptCore/runtime/FunctionRareData.h:29:10: fatal error: 'InternalFunctionAllocationProfile.h' file not found
#include "InternalFunctionAllocationProfile.h"
         ^
Comment 7 Csaba Osztrogonác 2016-01-12 03:23:45 PST 
Let's see if a clean build helps or not:
https://build.webkit.org/builders/Apple%20El%20Capitan%20CMake%20Debug%20%28Build%29/builds/1559
Comment 8 Keith Miller 2016-01-27 14:37:13 PST 
*** Bug 152710 has been marked as a duplicate of this bug. ***