Bug 152940 – Add display-list drawing hooks to platform-specific GraphicsContext files

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Add display-list drawing hooks to platform-specific GraphicsContext files

[Simon Fraser (smfr)]

Created attachment 268611 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 268612 [details]
Patch

[Simon Fraser (smfr)]

https://trac.webkit.org/r194816

[Ryan Haddad]

This change may be causing the Speedometer/Full.html Performance test to fail:

<https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK2%20%28Perf%29/builds/832>

[Simon Fraser (smfr)]

That's odd:

Running Speedometer/Full.html (151 of 151)
error: Speedometer/Full.html
GraphicsContext::roundToDevicePixels() is not yet compatible with recording contexts.
GraphicsContext::roundToDevicePixels() is not yet compatible with recording contexts.

The new code should not be enabled by default.

Zalan, can you look to see if I messed up with roundToDevicePixels()?

[Carlos Garcia Campos]

(In reply to comment #5)
> That's odd:
> 
> Running Speedometer/Full.html (151 of 151)
> error: Speedometer/Full.html
> GraphicsContext::roundToDevicePixels() is not yet compatible with recording
> contexts.
> GraphicsContext::roundToDevicePixels() is not yet compatible with recording
> contexts.
> 
> The new code should not be enabled by default.
> 
> Zalan, can you look to see if I messed up with roundToDevicePixels()?

Yes, the condition looks wrong in GraphicsContext::roundToDevicePixels

if (!isRecording()) {
    WTFLogAlways("GraphicsContext::roundToDevicePixels() is not yet compatible with recording contexts.");
    return frect;
}

I've just fixed it in r194889

[Simon Fraser (smfr)]

Weird that didn't break any layout tests.