Bug 152934 - FTL B3 should do varargs tail calls and stack overflows
Summary: FTL B3 should do varargs tail calls and stack overflows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 150279
  Show dependency treegraph
 
Reported: 2016-01-08 16:16 PST by Filip Pizlo
Modified: 2016-01-08 16:38 PST (History)
5 users (show)

See Also:


Attachments
the patch (3.43 KB, patch)
2016-01-08 16:18 PST, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-01-08 16:16:09 PST
Patch forthcoming.
Comment 1 Filip Pizlo 2016-01-08 16:18:42 PST
Created attachment 268597 [details]
the patch
Comment 2 WebKit Commit Bot 2016-01-08 16:20:59 PST
Attachment 268597 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:344:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:352:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2016-01-08 16:21:44 PST
Comment on attachment 268597 [details]
the patch

Hold on, this isn't working right.
Comment 4 Filip Pizlo 2016-01-08 16:24:01 PST
Comment on attachment 268597 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268597&action=review

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:345
> +                jit.copyCalleeSavesToVMCalleeSavesBuffer();

I have to add AllowMacroScratchRegisterUsage above here.
Comment 5 Saam Barati 2016-01-08 16:33:21 PST
Comment on attachment 268597 [details]
the patch

r=me
Comment 6 Filip Pizlo 2016-01-08 16:38:39 PST
Landed in http://trac.webkit.org/changeset/194805