Bug 152921 - Modern IDB: IDBBindingUtilities chokes on unicode strings for get/set
Summary: Modern IDB: IDBBindingUtilities chokes on unicode strings for get/set
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 149117 150882 152554
  Show dependency treegraph
 
Reported: 2016-01-08 13:06 PST by Brady Eidson
Modified: 2016-01-08 16:20 PST (History)
6 users (show)

See Also:


Attachments
Patch v1 (8.36 KB, patch)
2016-01-08 13:14 PST, Brady Eidson
achristensen: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (818.46 KB, application/zip)
2016-01-08 13:44 PST, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (786.98 KB, application/zip)
2016-01-08 14:06 PST, Build Bot
no flags Details
Archive of layout-test-results from ews117 for mac-yosemite (806.26 KB, application/zip)
2016-01-08 14:09 PST, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-01-08 13:06:59 PST
Modern IDB: IDBBindingUtilities chokes on unicode strings for get/set

get and set do an unnecessary utf8().data() call on the string they are passing, resulting in buggy property lookups or injections.

get() was covered by an existing failing test.
set() will be covered by a change to an existing test.
Comment 1 Brady Eidson 2016-01-08 13:14:33 PST
Created attachment 268575 [details]
Patch v1
Comment 2 Build Bot 2016-01-08 13:44:42 PST
Comment on attachment 268575 [details]
Patch v1

Attachment 268575 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/668253

New failing tests:
imported/w3c/indexeddb/keypath.htm
Comment 3 Build Bot 2016-01-08 13:44:44 PST
Created attachment 268579 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-01-08 14:06:12 PST
Comment on attachment 268575 [details]
Patch v1

Attachment 268575 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/668295

New failing tests:
imported/w3c/indexeddb/keypath.htm
Comment 5 Build Bot 2016-01-08 14:06:15 PST
Created attachment 268582 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-01-08 14:09:52 PST
Comment on attachment 268575 [details]
Patch v1

Attachment 268575 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/668291

New failing tests:
imported/w3c/indexeddb/keypath.htm
Comment 7 Build Bot 2016-01-08 14:09:56 PST
Created attachment 268583 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Brady Eidson 2016-01-08 14:18:55 PST
Yup, I forgot to include the updated results in the patch. My bad! They're there.
Comment 9 Brady Eidson 2016-01-08 14:21:58 PST
https://trac.webkit.org/changeset/194789