Bug 152900 – [ANGLE] Correct UNREACHABLE runtime assertion for void constructors

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Brent Fulgham]

The fix is just to remove the UNREACHABLE call in this name mangler. Several expected values pass through here and should not contribute to the mangled name. The ‘UNREACHBLE()’ call was not appropriate:

chromium / angle / angle / 01971113492d9aca386f2bca021b1f4b134fc277^! / .
commit	01971113492d9aca386f2bca021b1f4b134fc277	[log] [tgz]
author	Dmitry Skiba <[e-mail]>	Fri Jul 10 18:54:00 2015
committer	Jamie Madill <[e-mail]>	Fri Jul 10 19:03:34 2015
tree	47e42eac00f7d64cddb14b3cc21a4e605c189d20
parent	53b76107ece2f5b4dfc831f2b571f9db04d65c73 [diff]

diff --git a/src/compiler/translator/Types.cpp b/src/compiler/translator/Types.cpp
index 0b60eb1..62bcd8e 100644
--- a/src/compiler/translator/Types.cpp
+++ b/src/compiler/translator/Types.cpp
@@ -142,7 +142,8 @@
         mangledName += interfaceBlock->mangledName();
         break;
       default:
-        UNREACHABLE();
+        // EbtVoid, EbtAddress and non types
+        break;
     }
 
     if (isMatrix())

[Brent Fulgham]

Side note: We need to update ANGLE, and should try to keep more in sync with the upstream work. The patch that had this (small) fix also added some useful caching that would be nice to have in our code.

[Brent Fulgham]

Created attachment 268551 [details]
Patch

[Brent Fulgham]

<rdar://problem/24107501>

[WebKit Commit Bot]

Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE

[WebKit Commit Bot]

Comment on attachment 268551 [details]
Patch

Clearing flags on attachment: 268551

Committed r194780: <http://trac.webkit.org/changeset/194780>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.