RESOLVED FIXED 152895
[JSC] B3 is unable to do function calls on ARM64 
https://bugs.webkit.org/show_bug.cgi?id=152895
Summary [JSC] B3 is unable to do function calls on ARM64
Benjamin Poulain
Reported 2016-01-08 09:18:21 PST
[JSC] B3 is unable to do function calls on ARM64
Attachments
Patch (3.89 KB, patch)
2016-01-08 09:20 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2016-01-08 09:20:09 PST
Created attachment 268546 [details] Patch
Mark Lam
Comment 2 2016-01-08 09:30:19 PST
Comment on attachment 268546 [details] Patch r=me
WebKit Commit Bot
Comment 3 2016-01-10 13:43:04 PST
Comment on attachment 268546 [details] Patch Clearing flags on attachment: 268546 Committed r194831: <http://trac.webkit.org/changeset/194831>
WebKit Commit Bot
Comment 4 2016-01-10 13:43:08 PST
All reviewed patches have been landed. Closing bug.
Filip Pizlo
Comment 5 2016-01-10 17:00:54 PST
Comment on attachment 268546 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268546&action=review > Source/JavaScriptCore/b3/B3LowerToAir.cpp:1554 > +#if CPU(ARM64) && PLATFORM(IOS) We usually use "if (isARM64())" instead of "#if CPU(ARM64)" in the compiler, since that would be just as correct and a whole lot more clear. I think it would make sense to add an "isIOS()" function and turn this code into normal control flow.
Note You need to log in before you can comment on or make changes to this bug.