Bug 152895 - [JSC] B3 is unable to do function calls on ARM64
Summary: [JSC] B3 is unable to do function calls on ARM64
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-08 09:18 PST by Benjamin Poulain
Modified: 2016-01-10 17:00 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.89 KB, patch)
2016-01-08 09:20 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-01-08 09:18:21 PST 
[JSC] B3 is unable to do function calls on ARM64
Comment 1 Benjamin Poulain 2016-01-08 09:20:09 PST 
Created attachment 268546 [details]
Patch
Comment 2 Mark Lam 2016-01-08 09:30:19 PST 
Comment on attachment 268546 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2016-01-10 13:43:04 PST 
Comment on attachment 268546 [details]
Patch

Clearing flags on attachment: 268546

Committed r194831: <http://trac.webkit.org/changeset/194831>
Comment 4 WebKit Commit Bot 2016-01-10 13:43:08 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Filip Pizlo 2016-01-10 17:00:54 PST 
Comment on attachment 268546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268546&action=review

> Source/JavaScriptCore/b3/B3LowerToAir.cpp:1554
> +#if CPU(ARM64) && PLATFORM(IOS)

We usually use "if (isARM64())" instead of "#if CPU(ARM64)" in the compiler, since that would be just as correct and a whole lot more clear.  I think it would make sense to add an "isIOS()" function and turn this code into normal control flow.