Bug 152894 - run-webkit-tests mis-counts totals when there are other crashes
Summary: run-webkit-tests mis-counts totals when there are other crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-08 09:07 PST by Aakash Jain
Modified: 2017-03-15 17:16 PDT (History)
5 users (show)

See Also:

Attachments
Proposed patch (1.45 KB, patch)
2016-01-08 09:21 PST, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2016-01-08 09:07:43 PST 
see <rdar://problem/24098697>

When there are "other" crashes, the "didn't run" in run-webkit-tests output are wrong.

e.g.: 8 tests ran as expected, 2 didn't (-2 didn't run):

And:
15:34:07.115 52921 10 slowest tests that are not marked as SLOW and did not timeout/crash:
15:34:07.115 52921   http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-always.html took 2.7 seconds
15:34:07.115 52921   http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-default.html took 0.5 seconds
15:34:07.115 52921   http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer.html took 0.4 seconds
15:34:07.115 52921   http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer-when-downgrade.html took 0.4 seconds
15:34:07.115 52921   http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-never.html took 0.4 seconds
15:34:07.115 52921   http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-origin.html took 0.3 seconds
15:34:07.115 52921   http/tests/contentdispositionattachmentsandbox/referer-header-stripped.html took 0.3 seconds
15:34:07.115 52921   http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-unsafe-url.html took 0.3 seconds
15:34:07.115 52921   suggestd-53291 took 0.0 seconds
15:34:07.115 52921   suggestd-53097 took 0.0 seconds
15:34:07.115 52921 
15:34:07.115 52921 Tests marked as SLOW:
15:34:07.115 52921 
15:34:07.115 52921 Tests that timed out or crashed:
15:34:07.115 52921 
15:34:07.115 52921 Time to process slowest subdirectories:
15:34:07.115 52921    took 0.0 seconds to run 2 tests.
15:34:07.115 52921   all_tests took 5.9 seconds to run 8 tests.
15:34:07.115 52921 
15:34:07.115 52921 
15:34:07.115 52921 
15:34:07.115 52921 8 tests ran as expected, 2 didn't (-2 didn't run)
Comment 1 Aakash Jain 2016-01-08 09:21:04 PST 
Created attachment 268547 [details]
Proposed patch
Comment 2 Alexey Proskuryakov 2016-01-08 09:31:08 PST 
It would be good to add a regression test for this.
Comment 3 Aakash Jain 2016-01-08 09:34:23 PST 
ok, will add.
Comment 4 WebKit Commit Bot 2016-01-08 10:20:44 PST 
Comment on attachment 268547 [details]
Proposed patch

Clearing flags on attachment: 268547

Committed r194768: <http://trac.webkit.org/changeset/194768>
Comment 5 WebKit Commit Bot 2016-01-08 10:20:47 PST 
All reviewed patches have been landed.  Closing bug.