Bug 152894 – run-webkit-tests mis-counts totals when there are other crashes

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

see <rdar://problem/24098697>

When there are "other" crashes, the "didn't run" in run-webkit-tests output are wrong.

e.g.: 8 tests ran as expected, 2 didn't (-2 didn't run):

And:
15:34:07.115 52921 10 slowest tests that are not marked as SLOW and did not timeout/crash:
15:34:07.115 52921   http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-always.html took 2.7 seconds
15:34:07.115 52921   http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-default.html took 0.5 seconds
15:34:07.115 52921   http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer.html took 0.4 seconds
15:34:07.115 52921   http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-no-referrer-when-downgrade.html took 0.4 seconds
15:34:07.115 52921   http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-never.html took 0.4 seconds
15:34:07.115 52921   http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-origin.html took 0.3 seconds
15:34:07.115 52921   http/tests/contentdispositionattachmentsandbox/referer-header-stripped.html took 0.3 seconds
15:34:07.115 52921   http/tests/contentdispositionattachmentsandbox/referer-header-stripped-with-meta-referer-unsafe-url.html took 0.3 seconds
15:34:07.115 52921   suggestd-53291 took 0.0 seconds
15:34:07.115 52921   suggestd-53097 took 0.0 seconds
15:34:07.115 52921 
15:34:07.115 52921 Tests marked as SLOW:
15:34:07.115 52921 
15:34:07.115 52921 Tests that timed out or crashed:
15:34:07.115 52921 
15:34:07.115 52921 Time to process slowest subdirectories:
15:34:07.115 52921    took 0.0 seconds to run 2 tests.
15:34:07.115 52921   all_tests took 5.9 seconds to run 8 tests.
15:34:07.115 52921 
15:34:07.115 52921 
15:34:07.115 52921 
15:34:07.115 52921 8 tests ran as expected, 2 didn't (-2 didn't run)

[Aakash Jain]

Created attachment 268547 [details]
Proposed patch

[Alexey Proskuryakov]

It would be good to add a regression test for this.

[Aakash Jain]

ok, will add.

[WebKit Commit Bot]

Comment on attachment 268547 [details]
Proposed patch

Clearing flags on attachment: 268547

Committed r194768: <http://trac.webkit.org/changeset/194768>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.