Bug 152885 - [mips] Fixed unused parameter warnings
Summary: [mips] Fixed unused parameter warnings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-08 03:44 PST by Konstantin Tokarev
Modified: 2016-01-08 08:55 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.54 KB, patch)
2016-01-08 03:48 PST, Konstantin Tokarev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-01-08 03:44:53 PST
Fixed unused parameter warnings
Comment 1 Konstantin Tokarev 2016-01-08 03:48:28 PST
Created attachment 268535 [details]
Patch
Comment 2 Mark Lam 2016-01-08 06:20:20 PST
Comment on attachment 268535 [details]
Patch

This looks like a bug.  Applying this patch would cover up the bug.  We should find out who is using these setupArgumentsWithExecState that is ignoring the TrustedImm32.
Comment 3 Konstantin Tokarev 2016-01-08 06:31:07 PST
Mark, it looked as bug for me too, but  Julien Brianceau explained me that this is the dummy argument used to pass 64-bit arguments.

Source/JavaScriptCore/jit/JITInlines.h:583 defines EABI_32BIT_DUMMY_ARG which is then used in setupArgumentsWithExecState invocations.
Comment 4 Julien Brianceau 2016-01-08 06:44:09 PST
I see two solutions here:

1) We actually setup the dummy argument, which is not a big deal (one move opcode)

2) We add somethink like this instead to check that this is actually the expected EABI_32BIT_DUMMY_ARG.

    RELEASE_ASSERT(arg1.m_value == 0);
Comment 5 Konstantin Tokarev 2016-01-08 07:00:27 PST
Better option for (2) would be ASSERT_UNUSED(arg1, arg1.m_value == 0);
Comment 6 Mark Lam 2016-01-08 08:04:10 PST
(In reply to comment #5)
> Better option for (2) would be ASSERT_UNUSED(arg1, arg1.m_value == 0);

I've looked at the code some more and see that this is the current accepted practice for dealing with EABI_32BIT_DUMMY_ARG.  I think there are better ways to do this, but the current patch is adequate.  I will r+ the patch.
Comment 7 WebKit Commit Bot 2016-01-08 08:55:24 PST
Comment on attachment 268535 [details]
Patch

Clearing flags on attachment: 268535

Committed r194766: <http://trac.webkit.org/changeset/194766>
Comment 8 WebKit Commit Bot 2016-01-08 08:55:27 PST
All reviewed patches have been landed.  Closing bug.