Bug 152881 – [Content Filtering] Lazily load platform frameworks

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[Content Filtering] Lazily load platform frameworks

[Andy Estes]

rdar://problem/23270886

[Andy Estes]

Created attachment 268618 [details]
Patch

[WebKit Commit Bot]

Attachment 268618 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:292:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andy Estes]

Created attachment 268619 [details]
Patch

[WebKit Commit Bot]

Attachment 268619 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:292:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 268619 [details]
Patch

Attachment 268619 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/670433

New failing tests:
http/tests/appcache/load-from-appcache-defer-resume-crash.html
http/tests/appcache/offline-access.html
http/tests/appcache/main-resource-hash.html
http/tests/appcache/top-frame-2.html
http/tests/appcache/reload.html
http/tests/appcache/history-test.html
http/tests/appcache/top-frame-4.html
http/tests/appcache/non-html.xhtml
http/tests/appcache/cyrillic-uri.html
http/tests/appcache/crash-when-navigating-away-then-back.html
http/tests/appcache/local-content.html
http/tests/appcache/top-frame-3.html
http/tests/appcache/remove-cache.html
http/tests/appcache/xhr-foreign-resource.html
http/tests/appcache/x-frame-options-prevents-framing.php

[Build Bot]

Created attachment 268620 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Andy Estes]

Created attachment 268642 [details]
Patch

[WebKit Commit Bot]

Attachment 268642 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:292:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

Comment on attachment 268642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268642&action=review

I love the source changes.

I did not look *that* closely at the testing changes but they seem quite sane.

> Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:76
> +    m_queue = adoptOSObject(dispatch_queue_create("com.apple.WebCore.NEFilterSourceQueue", DISPATCH_QUEUE_SERIAL));

I know this is preexisting, but maybe now is a good time to reconsider this queue's name.

There's no rule that we have to use "reverse domain bundle formatting" for these, and it is likely beneficial to WebKit developers and crash reporter analyzers to have an immediately human readable name.

I'd suggest "WebKit Content Filtering" or, if you object to "WebKit" being used in WebCore, then "Web Content Filtering"

[Andy Estes]

(In reply to comment #10)
> Comment on attachment 268642 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=268642&action=review
> 
> I love the source changes.
> 
> I did not look *that* closely at the testing changes but they seem quite
> sane.
> 
> > Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:76
> > +    m_queue = adoptOSObject(dispatch_queue_create("com.apple.WebCore.NEFilterSourceQueue", DISPATCH_QUEUE_SERIAL));
> 
> I know this is preexisting, but maybe now is a good time to reconsider this
> queue's name.
> 
> There's no rule that we have to use "reverse domain bundle formatting" for
> these, and it is likely beneficial to WebKit developers and crash reporter
> analyzers to have an immediately human readable name.
> 
> I'd suggest "WebKit Content Filtering" or, if you object to "WebKit" being
> used in WebCore, then "Web Content Filtering"

Ok, I agree. I think "Web(Kit) Content Filtering" might be a little misleading, since this is specifically for the NEFilterSource variant. Maybe "WebKit NEFilterSource Filtering"?

[Andy Estes]

Committed r194950: <http://trac.webkit.org/changeset/194950>

[Andy Estes]

(In reply to comment #12)
> Committed r194950: <http://trac.webkit.org/changeset/194950>

Oops, I forgot to make the change Brady suggested. Addressed in r194951: <http://trac.webkit.org/changeset/194951>