Bug 152876 - Correct missing EXT_sRGB Format Handling
Summary: Correct missing EXT_sRGB Format Handling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Brent Fulgham
URL: https://www.khronos.org/registry/webg...
Keywords: InRadar
Depends on: 109332
Blocks:
  Show dependency tree / graph
 
Reported: 2016-01-07 17:52 PST by Brent Fulgham
Modified: 2016-01-07 18:52 PST (History)
9 users (show)

See Also:

Attachments
Patch (3.87 KB, patch)
2016-01-07 18:02 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-01-07 17:52:11 PST 
When we added EXT_sRGB support to WebGL in Bug 109332, a couple of places were missed for the case of using SRGB as a texture source. This was identified by the WebGL 1.0.4 test suite.
Comment 1 Brent Fulgham 2016-01-07 17:53:12 PST 
<rdar://problem/23284389>
Comment 2 Brent Fulgham 2016-01-07 18:02:12 PST 
Created attachment 268518 [details]
Patch
Comment 3 WebKit Commit Bot 2016-01-07 18:04:13 PST 
Attachment 268518 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:507:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 David Kilzer (:ddkilzer) 2016-01-07 18:18:21 PST 
(In reply to comment #3)
> Attachment 268518 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:507:  enum
> members should use InterCaps with an initial capital letter or initial 'k'
> for C-style enums.  [readability/enum_casing] [4]
> Total errors found: 1 in 4 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

Didn't I fix this?  Maybe my check-style change wasn't broad enough.
Comment 5 David Kilzer (:ddkilzer) 2016-01-07 18:21:03 PST 
(In reply to comment #4)
> (In reply to comment #3)
> > Attachment 268518 [details] did not pass style-queue:
> > 
> > 
> > ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:507:  enum
> > members should use InterCaps with an initial capital letter or initial 'k'
> > for C-style enums.  [readability/enum_casing] [4]
> > Total errors found: 1 in 4 files
> > 
> > 
> > If any of these errors are false positives, please file a bug against
> > check-webkit-style.
> 
> Didn't I fix this?  Maybe my check-style change wasn't broad enough.

Oh, not a 'k' constant.  Different issue.
Comment 6 WebKit Commit Bot 2016-01-07 18:52:00 PST 
Comment on attachment 268518 [details]
Patch

Clearing flags on attachment: 268518

Committed r194751: <http://trac.webkit.org/changeset/194751>
Comment 7 WebKit Commit Bot 2016-01-07 18:52:06 PST 
All reviewed patches have been landed.  Closing bug.