Bug 152875 – Modern IDB: Success-after-open event should only have the IDBOpenDBRequest as its target

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brady Eidson]

Modern IDB: Success-after-open event should only have the IDBOpenDBRequest as its target

As opposed to other request-related events which also capture/bubble to the transaction and the IDBDatabase

[Brady Eidson]

Created attachment 268515 [details]
Patch v1

[Alex Christensen]

Comment on attachment 268515 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=268515&action=review

> Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp:284
> +    if (&event == m_openDatabaseSuccessEvent)

You do this comparison unnecessarily twice.  I think it should look like this:

if (&event == m_openDatabaseSuccessEvent)
    m_openDatabaseSuccessEvent = nullptr;
else if (m_transaction) {
...
}

[Brady Eidson]

Created attachment 268528 [details]
Patch for landing

[WebKit Commit Bot]

Attachment 268528 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/indexeddb/client/IDBRequestImpl.cpp:279:  Extra space before ) in if  [whitespace/parens] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

Created attachment 268529 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 268529 [details]
Patch for landing

Clearing flags on attachment: 268529

Committed r194754: <http://trac.webkit.org/changeset/194754>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.