Bug 152870 - Cleanup: XSS Auditor should avoid re-evaluating the parsed script tag
Summary: Cleanup: XSS Auditor should avoid re-evaluating the parsed script tag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: BlinkMergeCandidate, XSSAuditor
Depends on:
Blocks:
 
Reported: 2016-01-07 16:57 PST by Daniel Bates
Modified: 2016-01-13 13:45 PST (History)
4 users (show)

See Also:


Attachments
Patch (3.59 KB, patch)
2016-01-07 16:58 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-01-07 16:57:40 PST
Currently the XSS Auditor caches the decoded start tag of a script as an optimization to avoid decoding it again when filtering the character data of the script. We can do reduce memory usage by caching a boolean as to whether HTTP response contains the decoded string instead of caching the decoded string.

Blink Issue: <https://chromiumcodereview.appspot.com/19446002>
Comment 1 Daniel Bates 2016-01-07 16:58:36 PST
Created attachment 268508 [details]
Patch
Comment 2 Brent Fulgham 2016-01-13 12:48:50 PST
Comment on attachment 268508 [details]
Patch

r=me.
Comment 3 WebKit Commit Bot 2016-01-13 13:45:21 PST
Comment on attachment 268508 [details]
Patch

Clearing flags on attachment: 268508

Committed r194982: <http://trac.webkit.org/changeset/194982>
Comment 4 WebKit Commit Bot 2016-01-13 13:45:24 PST
All reviewed patches have been landed.  Closing bug.