Bug 152862 - Add a waitUntilReady() step
Summary: Add a waitUntilReady() step
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jon Lee
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-01-07 14:30 PST by Jon Lee
Modified: 2016-01-07 16:11 PST (History)
7 users (show)

See Also:


Attachments
Patch (3.82 KB, patch)
2016-01-07 15:13 PST, Jon Lee
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jon Lee 2016-01-07 14:30:10 PST
Allow benchmarks an opportunity to setup before running.
Comment 1 Radar WebKit Bug Importer 2016-01-07 14:30:20 PST
<rdar://problem/24097315>
Comment 2 Jon Lee 2016-01-07 15:13:23 PST
Created attachment 268498 [details]
Patch
Comment 3 Said Abou-Hallawa 2016-01-07 15:36:29 PST
Comment on attachment 268498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268498&action=review

> PerformanceTests/Animometer/tests/resources/main.js:357
> +            function resolveWhenFinished() {

Just for consistency, can't we get rid of 'var self = this' and use something like

var resolveWhenFinished = function() { .... }.bind(this);
....

resolveWhenFinished();
Comment 4 Jon Lee 2016-01-07 15:55:03 PST
Comment on attachment 268498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=268498&action=review

>> PerformanceTests/Animometer/tests/resources/main.js:357
>> +            function resolveWhenFinished() {
> 
> Just for consistency, can't we get rid of 'var self = this' and use something like
> 
> var resolveWhenFinished = function() { .... }.bind(this);
> ....
> 
> resolveWhenFinished();

Sure.
Comment 5 Jon Lee 2016-01-07 16:11:08 PST
Committed r194743: <http://trac.webkit.org/changeset/194743>