RESOLVED FIXED 152862
Add a waitUntilReady() step
https://bugs.webkit.org/show_bug.cgi?id=152862
Summary Add a waitUntilReady() step
Jon Lee
Reported 2016-01-07 14:30:10 PST
Allow benchmarks an opportunity to setup before running.
Attachments
Patch (3.82 KB, patch)
2016-01-07 15:13 PST, Jon Lee
simon.fraser: review+
Radar WebKit Bug Importer
Comment 1 2016-01-07 14:30:20 PST
Jon Lee
Comment 2 2016-01-07 15:13:23 PST
Said Abou-Hallawa
Comment 3 2016-01-07 15:36:29 PST
Comment on attachment 268498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268498&action=review > PerformanceTests/Animometer/tests/resources/main.js:357 > + function resolveWhenFinished() { Just for consistency, can't we get rid of 'var self = this' and use something like var resolveWhenFinished = function() { .... }.bind(this); .... resolveWhenFinished();
Jon Lee
Comment 4 2016-01-07 15:55:03 PST
Comment on attachment 268498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268498&action=review >> PerformanceTests/Animometer/tests/resources/main.js:357 >> + function resolveWhenFinished() { > > Just for consistency, can't we get rid of 'var self = this' and use something like > > var resolveWhenFinished = function() { .... }.bind(this); > .... > > resolveWhenFinished(); Sure.
Jon Lee
Comment 5 2016-01-07 16:11:08 PST
Note You need to log in before you can comment on or make changes to this bug.