WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
152856
Use wavy offset for decoration painting when line style is TextDecorationStyleWavy.
https://bugs.webkit.org/show_bug.cgi?id=152856
Summary
Use wavy offset for decoration painting when line style is TextDecorationStyl...
zalan
Reported
2016-01-07 13:58:11 PST
SSIA.
Attachments
Patch
(4.45 KB, patch)
2016-01-07 14:00 PST
,
zalan
no flags
Details
Formatted Diff
Diff
Patch
(4.95 KB, patch)
2016-01-07 14:46 PST
,
zalan
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
zalan
Comment 1
2016-01-07 14:00:06 PST
Created
attachment 268483
[details]
Patch
Simon Fraser (smfr)
Comment 2
2016-01-07 14:08:33 PST
Comment on
attachment 268483
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=268483&action=review
> Source/WebCore/rendering/TextDecorationPainter.cpp:334 > + FloatPoint start(localOrigin.x(), localOrigin.y() + offset + wavyOffset); > + FloatPoint end(localOrigin.x() + m_width, localOrigin.y() + offset + wavyOffset);
Minor pref for localOrigin + FloatSize(...)
> Source/WebCore/rendering/TextDecorationPainter.cpp:339 > + FloatPoint start(localOrigin.x(), localOrigin.y() - wavyOffset);
Minor pref for localOrigin - FloatSize(0, wavyOffset) here
zalan
Comment 3
2016-01-07 14:46:58 PST
Created
attachment 268496
[details]
Patch
WebKit Commit Bot
Comment 4
2016-01-07 15:33:22 PST
Comment on
attachment 268496
[details]
Patch Clearing flags on attachment: 268496 Committed
r194736
: <
http://trac.webkit.org/changeset/194736
>
WebKit Commit Bot
Comment 5
2016-01-07 15:33:25 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug